amakvana / SwitchEmuModDownloader

SwitchEmuModDownloader - A Cross-Platform One-Click Games Mod Downloader for Switch emulators. Formerly YuzuModDownloader.
GNU General Public License v3.0
567 stars 35 forks source link

YuzuModDownloader not downloading from theboy181 and crashing when unpacking from HolographicWings #25

Closed ghost closed 6 months ago

ghost commented 1 year ago

YuzuModDownloader not loading anything from theboy181 and crashing when downloading from HolographicWings.

Steps to reproduce the behavior:

  1. Open YuzuModDownloader
  2. Click on Download
  3. Only Downloading from the first Github

Expected behavior It downloading every Mod available for every Game installed

Screenshots (https://youtu.be/zm2eK2WZE2Q)

Desktop/Laptop (please complete the following information):

Additional context My AdBlocker AdGuard doesnt change anything if enabled or disabled.

amakvana commented 1 year ago

Thanks for the video, that helps alot! Would you be able to keep it online until this is sorted?

For theboy181's repo, you'll need to make sure your games match up to the specific Game ID's and also ensure the version also matches, as his repo only contains mods for certain versions of games listed.

I will check the TOTK mods and see what's playing up with them

ghost commented 1 year ago

Bayonetta 3 Game ID: 01004A4010FEA000 Update Version 1.2.0

The Last time: https://github.com/amakvana/YuzuModDownloader/issues/23 it worked fine after he made the 1.2.0 Version available on his Github.

And it should work now too, but it doesnt for some reason.

amakvana commented 1 year ago

Bayonetta 3 Game ID: 01004A4010FEA000 Update Version 1.2.0

The Last time: #23 it worked fine after he made the 1.2.0 Version available on his Github.

And it should work now too, but it doesnt for some reason.

I'll try reproducing the error you're getting with this ^

However, I am struggling to reproduce the error you're getting with the TOTK repo, same game version, same title ID. See gif below:

ymd-totk-112

I wonder if it could be a permission issue within some of your directories? Have you tried running YuzuModDownloader as Administrator?

ghost commented 1 year ago

Still crashes

amakvana commented 1 year ago

Strange! Could you provide me with the installation path of yuzu on your machine? Along with where the "mod load root" path points to?

ghost commented 1 year ago

C:\Users\Phynix\AppData\Roaming\yuzu F:\Games\Emulator\Switch\Yuzu\Data\load

amakvana commented 1 year ago

Have you got many mods populated within the \load\ folder already? I'm thinking potentially deleting the folder and letting Yuzu remake them, before retrying to download the Mods.

Have you placed YuzuModDownloader within C:\Users\Phynix\AppData\Roaming\yuzu too, right?

ghost commented 1 year ago

I already tried deleting everything inside load multiple times and no i did not put it inside the installation Folder, cause the first Github thingy works everywhere i put YuzuModDownloader, but sure, i can try.

Edit: Did not do anything.

amakvana commented 1 year ago

Okay, what's inside the following folder?

F:\Games\Emulator\Switch\Yuzu\Data\load\0100F2C0115B6000

ghost commented 1 year ago

Nothing

amakvana commented 1 year ago

There should be the TOTK-Mods-Collection-v2.3-1.1.2.7z archive since it crashed midway through, implying the "clean up" portion of the software would never have been reached.

Are you able to upload your qt-config.ini file onto here so I can have a quick look through? It'll be located in C:\Users\Phynix\AppData\Roaming\yuzu\config

ghost commented 1 year ago

YuzuModDownloader automatically deletes thos files or not?

If not because it crashes, then i might have deleted it on my own.

qt-config.zip

amakvana commented 1 year ago

YuzuModDownloader automatically deletes thos files or not?

It'll delete the archive once everything has been successfully extracted

amakvana commented 1 year ago

Okay try this for me:

  1. Close both Yuzu and YuzuModDownloader - make sure no tasks containing the word "yuzu" appear inside Task Manager.
  2. Download the qt-config.zip archive attached below.
  3. Extract the qt-config.zip archive somewhere.
  4. Copy the qt-config.ini file you have downloaded, then paste and override the old qt-config.ini file inside C:\Users\Phynix\AppData\Roaming\yuzu\config. When prompted to override, confirm it.
  5. Launch Yuzu, wait for your games to appear then close Yuzu.
  6. Open YuzuModDownloader and try again.

qt-config.zip

Let me know how you get on.

ghost commented 1 year ago

HolographicWings did Unpack for no reason at all now, after using your qt-config.ini, but theboy181 still does not find any Game i have installed, even tho i still have the same Bayonetta 3 Game ID and Version Number like the last time.

amakvana commented 1 year ago

HolographicWings did Unpack for no reason at all now, after using your qt-config.ini

That's because I modified your qt-config.ini, there was a couple of broken entries in there

but theboy181 still does not find any Game i have installed, even tho i still have the same Bayonetta 3 Game ID and Version Number like the last time.

I think I have figured it out! Recently GitHub have changed their UI design of the mod pages, so I am sure the scraping technique I'm using is now "invalidated". I'm going to have a look, refine it and post a test build inside here for you to try out.

Let me know if this works

amakvana commented 1 year ago

Update - the way GitHub now loads the mods into the browser is through JS via React. I don't think HtmlAgilityPack is capable of scraping this way. So I will look into rewriting this with Selenium instead. Once I have a working solution, I will post back in here

ghost commented 1 year ago

Well, thank you for helping, finding stuff out and even trying to fix things that consume time of your freetime.

Very appreciated and see you until then again.

CozMedic commented 11 months ago

Apologies, I know this is already being worked on & I appreciate your time looking into & resolving the issue. I just wanted to +1 that I'm experiencing the same issue. Seems unlikely, but in case it's of any use, I'm happy to provide my qt-config.ini or paths as well.

Thanks again.

amakvana commented 6 months ago

@CozMedic

Apologies for the late reply! Have a look at the link below, try the test build there and see if it resolves the issues

https://github.com/amakvana/YuzuModDownloader/issues/33#issuecomment-1915782814

Cheers!

amakvana commented 6 months ago

Closed - Fixed in v1.4.1.0 https://github.com/amakvana/YuzuModDownloader/releases/latest