amakvana / SwitchEmuModDownloader

SwitchEmuModDownloader - A Cross-Platform One-Click Games Mod Downloader for Switch emulators. Formerly YuzuModDownloader.
GNU General Public License v3.0
567 stars 35 forks source link

Downloader crashes when unpacking for Shin Megami Tensei V #37

Closed brolio closed 6 months ago

brolio commented 6 months ago

Describe the bug When downloading from the official switch mods repo the app gets stuck for a couple of seconds on unpacking the file Config_SMTV_1080p.zip and then closes itself with no further message

To Reproduce Steps to reproduce the behavior:

  1. open the downloader
  2. select the official mod repo
  3. click download mods
  4. wait
  5. crash

Expected behavior It should complete the download and give a recap message at the end of it

Screenshots immagine immagine immagine

Desktop (please complete the following information):

Additional context at first i thought it was caused by a "mismatch" in game versions since the last patch for it is 1.0.2 while the wiki i think it lists only up to 1.0.1, but i tried uninstalling the update alltogether and the problem persists, though as you can see in the second and third screenshots it seems like it's able to download and actually unpack something before crashing

amakvana commented 6 months ago

Thanks for opening up the issue!

It looks some of the Mediafire links are timing out. I'll need to amend the code to handle this.

Once done, I'll post a test build in here for you to confirm if it works fine on your end

Cheers!

amakvana commented 6 months ago

Hi @brolio,

Please can you download the test build attached and see if the issue persists - same instructions as usual.

There are a few performance optimisations too so it should feel snappier.

Cheers!

YMD_1.4.2.0_Test_Build_winx64.zip

brolio commented 6 months ago

Hi, probably a dumb question, but windows defender immediately blocks it as soon as i try to open the .zip archive, is it expected behaviour since it's a test build? immagine

EDIT: added screenshot, sorry it's in italian

amakvana commented 6 months ago

Hi, probably a dumb question, but windows defender immediately blocks it as soon as i try to open the .zip archive, is it expected behaviour since it's a test build?

EDIT: added screenshot, sorry it's in italian

No worries, you're correct. I haven't submitted it to Microsoft as its a test build.

The final release will be submitted to Microsoft so this issue won't occur. For now, add an exception then test.

For peace of mind, I have submitted it to VirusTotal, see results below:

https://www.virustotal.com/gui/url/bbf40d583971686c408724df8f8bf3dba6b3a50aad1d049341301d39621f402f?nocache=1

brolio commented 6 months ago

Seems to work like a charm now! immagine

Keep up the great work!

amakvana commented 6 months ago

Seems to work like a charm now!

Keep up the great work!

Thanks for confirming! I will push the changes out over the weekend

amakvana commented 6 months ago

Closed - Fixed in v1.4.2.0 https://github.com/amakvana/YuzuModDownloader/releases/latest