amalieeh / assessment-support

TDT4501 Computer Science, Specialization Project (2021 FALL) with Sylvi Phuong Huynh @sylvihuynh. About Learning technology.
0 stars 0 forks source link

81 sort answers #104

Closed sylvihuynh closed 2 years ago

sylvihuynh commented 2 years ago

fix #81

Created a drop down sorting box where the user can choose to sort the student answers byb:

This currently works for the case when the data is loaded and no assessments have been made. It later needs to be updated to only sort the rest of the assessments that have not been assessed. This is in relation to data retrieval for textboxes.

amalieeh commented 2 years ago

Nice work!!

I feel like the box is a bit "unaligned" with the oppgavebeskrivelse-section, but I think it is nice that it is clear that it is in no connection to oppgavebeskrivelse. Also i think this is something #88 or another css-issue can look at. (Personally, I think that the oppgavebeskrivelse-section should be moved down to align with the textboxes)

image

So I think that no change is needed, just shared a thought.

Edit: Actually I see that the oppgavebeskrivelser-section used to be aligned with the texboxes. Is it hard to fix? I get if the change happens in #105 instead of here so you dont get rebase issues

sylvihuynh commented 2 years ago

Nice work!!

I feel like the box is a bit "unaligned" with the oppgavebeskrivelse-section, but I think it is nice that it is clear that it is in no connection to oppgavebeskrivelse. Also i think this is something #88 or another css-issue can look at. (Personally, I think that the oppgavebeskrivelse-section should be moved down to align with the textboxes) image

So I think that no change is needed, just shared a thought.

Edit: Actually I see that the oppgavebeskrivelser-section used to be aligned with the texboxes. Is it hard to fix? I get if the change happens in #105 instead of here so you dont get rebase issues

I agree, and will take a look at it 👍

sylvihuynh commented 2 years ago

I added margin to the oppgavebeskrivelse-section, but as I do not know the size of the sorting box I added margin by eye, so please have a look too 👁️

amalieeh commented 2 years ago

Makes aaall the difference! :))

But now it seems like the alignment of the oppgavebeskrivelse-section and textboxes is gone? Like you fixed earlier with margin-top:59 or something like that. Does it look like this on your computer as well? Was it on purpose? image