search

amalieeh / assessment-support

TDT4501 Computer Science, Specialization Project (2021 FALL) with Sylvi Phuong Huynh @sylvihuynh. About Learning technology.
0 stars 0 forks source link

Set scores on approval page #112

Closed amalieeh closed 2 years ago

amalieeh commented 2 years ago

Fix #107 You set scores on approval page. If you un-set a score on the approval page, the border turns red, indicating that a change is needed. Also aligned the text with candidate number.

It only changes state, not the local storage, but I think that makes sorta sense, at least as of now. But later, maybe it should be updated in local storage so that the user comes back to resolved "konflikter".

sylvihuynh commented 2 years ago

🔥 with the red border on the unsetting on approval page

amalieeh commented 2 years ago

@sylvihuynh , you can test it again if you want and merge it next time you're in:) I think it should be fine, but I dont wanna merge messy code and the you'll have to deal with it 😅

sylvihuynh commented 2 years ago

@amalieeh when there is a conflict and a new score is set, it does not get updated. Score is still an empty string "". I still merged it though as I needed the page for #66

sylvihuynh commented 2 years ago

@amalieeh when there is a conflict and a new score is set, it does not get updated. Score is still an empty string "". I still merged it though as I needed the page for #66

nvm.... my mistake. The saving function was not updated for this new PR 😵‍💫