amanchadha / iSeeBetter

iSeeBetter: Spatio-Temporal Video Super Resolution using Recurrent-Generative Back-Projection Networks | Python3 | PyTorch | GANs | CNNs | ResNets | RNNs | Published in Springer Journal of Computational Visual Media, September 2020, Tsinghua University Press
https://arxiv.org/abs/2006.11161
MIT License
363 stars 68 forks source link

Same resolution output image #19

Closed tthg119 closed 3 years ago

tthg119 commented 3 years ago

Hi there, can you please check again your model code? I run the test file with your pretrained models and all default args (with and without --upscale_only flag), the output result image is always the same as the input's. It evenly looks blurrier than the input itself, as upscaled and downscaled again I think? I also tried running with different args but it seems the problem is in your model's output. Also tried with different random images, the output is the same as well.

tthg119 commented 3 years ago

I debugged your code and saw that you didn't pass the upscale_only argument in all the functions in data.py.

amanchadha commented 3 years ago

Thanks for identifying the issue. Can you open up a merge request with your changes? That would be well appreciated :)

amanchadha commented 3 years ago

Check with -u, just merged some fixes in https://github.com/amanchadha/iSeeBetter/commit/eb54b27cf044fa85f783729291fb393b73eb082b

spigelli commented 3 years ago

That merge was for an unrelated issue. Seems like it's still downscaling before upscaling even with -u. I'm running:

python3 iSeeBetterTest.py -o <mounted directory> -c --data_dir <dir containing file list and dir of images> --file_list <file list name> --upscale_only

Tested with netG_epoch_4_1 and the FullDataSet version of that model. Here's the docker file for the container I'm running everything in for reference: Dockerfile gist

nigh8w0lf commented 3 years ago

That merge was for an unrelated issue. Seems like it's still downscaling before upscaling even with -u. I'm running:

python3 iSeeBetterTest.py -o <mounted directory> -c --data_dir <dir containing file list and dir of images> --file_list <file list name> --upscale_only

Tested with netG_epoch_4_1 and the FullDataSet version of that model. Here's the docker file for the container I'm running everything in for reference: Dockerfile gist

Yes, I'm seeing the same thing https://github.com/amanchadha/iSeeBetter/issues/21