search

amanchokshi / EMBERS

Experimental Measurement of BEam Responses with Satellites
https://embers.readthedocs.io
MIT License
3 stars 1 forks source link

requirements.txt too "fixed"? #5

Open teuben opened 3 years ago

teuben commented 3 years ago

I noticed that a lot of packages have a fixed required version (although e.g. seaborn and skyfield have a min.version). Especially the odd versioning of astropy I found odd. I don't have a good solution for this, as obviously any of these packages that was upgraded could break the test.

amanchokshi commented 3 years ago

@teuben Thanks for pointing this out Peter! I recently had a problem where a more recent version of h5py broke my tests because mwa-pb wouldn't function with the latest version. I'll look into it and see if I can make some of the packages more flexible with minimum versions instead of hardcoded ones. I've also been looking into Poetry for dependancy managing and packaging. It seems to have significant advantages, but would require significant effort to rework embers as of now. I'll definitely use it for future projects.

teuben commented 3 years ago

I realize this is the conservative approach that "just works", since you used freeze and got it working with that version. But pretty soon this is old, and a lot of users will find themselves with virtual env directories that may take a lot of time compiling, and taking up disk space. Again, I don't have a good solution for this. Having a lot of python packages in ones' portfolio is going to be a nightmare to maintain. Not to mention if you want to use package A and B in one script and they have different venv's. Sigh.