search

amandablum / mindup

1 stars 0 forks source link

newsletter error is throwing off CSS #115

Closed amandablum closed 8 years ago

amandablum commented 8 years ago

hold on any fix here. lets do it post dev.

2016-04-21_0735

chuckreynolds commented 8 years ago

i know this is for cee but what browser is that? In chrome (edit: mac) it's fine: screen shot 2016-04-21 at 12 18 43

amandablum commented 8 years ago

chrome, weirdly. windows. ill test and get more deets before assigning. On Apr 21, 2016 12:19 PM, "Chuck Reynolds" notifications@github.com wrote:

i know this is for cee but what browser is that? In chrome it's fine: [image: screen shot 2016-04-21 at 12 18 43] https://cloud.githubusercontent.com/assets/46185/14721444/43da0460-07bb-11e6-8abc-8770dad22d05.png

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/115#issuecomment-213077654

vitamincee commented 8 years ago

does this happen in firefox on windows? i don't have windows to test...

amandablum commented 8 years ago

chrome. i'll check firefox too. you can use my browserlab acct. will send creds.

On Wed, Apr 27, 2016 at 5:30 PM, cee notifications@github.com wrote:

does this happen in firefox on windows? i don't have windows to test...

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/115#issuecomment-215272588

amandablum commented 8 years ago

firefox too.

On Wed, Apr 27, 2016 at 5:43 PM, Amanda Blum - Howling Zoe Productions < amanda@howlingzoe.com> wrote:

chrome. i'll check firefox too. you can use my browserlab acct. will send creds.

On Wed, Apr 27, 2016 at 5:30 PM, cee notifications@github.com wrote:

does this happen in firefox on windows? i don't have windows to test...

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/115#issuecomment-215272588

vitamincee commented 8 years ago

Could not re-create bug on browser stack - need more info.

Here's a screenshot of Chrome 50 (latest) on Win 7

screen shot 2016-04-27 at 7 30 48 pm

amandablum commented 8 years ago

disabled all plugins, etc. its on firefox and chrome. on multiple computers.

On Wed, Apr 27, 2016 at 7:40 PM, cee notifications@github.com wrote:

Could not re-create bug on browser stack - need more info.

Here's a screenshot of Chrome 50 (latest) on Win 7

[image: screen shot 2016-04-27 at 7 30 48 pm] https://cloud.githubusercontent.com/assets/1355874/14873885/b8e1c254-0caf-11e6-90ea-8a14efcafdd3.png

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/115#issuecomment-215291847

amandablum commented 8 years ago

k. here's what I can tell. its not the button, its the form field.

without anything in the field: 2016-04-27_2115 with an error in the field: 2016-04-27_2115_001

amandablum commented 8 years ago

.gform_wrapper li.gfield.gfield_error.gfield_contains_required div.ginput_container, .gform_wrapper li.gfield.gfield_error.gfield_contains_required label.gfield_label {

  1. margin-top: .375em;

} .gform_wrapper li.gfield.gfield_error.gfield_contains_required {

  1. /* margin-top: .75em; */
  2. margin-bottom: .75em!important;

}

I think this might solve it.

On Wed, Apr 27, 2016 at 9:12 PM, Amanda Blum - Howling Zoe Productions < amanda@howlingzoe.com> wrote:

disabled all plugins, etc. its on firefox and chrome. on multiple computers.

On Wed, Apr 27, 2016 at 7:40 PM, cee notifications@github.com wrote:

Could not re-create bug on browser stack - need more info.

Here's a screenshot of Chrome 50 (latest) on Win 7

[image: screen shot 2016-04-27 at 7 30 48 pm] https://cloud.githubusercontent.com/assets/1355874/14873885/b8e1c254-0caf-11e6-90ea-8a14efcafdd3.png

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/115#issuecomment-215291847

vitamincee commented 8 years ago

i added this code to my dev site - please test on your end to see if it fixes it.

amandablum commented 8 years ago

fixed things on my end. are you seeing anything negative on yours?

On Thu, Apr 28, 2016 at 10:05 AM, cee notifications@github.com wrote:

i added this code to my dev site - please test on your end to see if it fixes it.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/115#issuecomment-215496230

vitamincee commented 8 years ago

i notice no change here (so still looks good)

amandablum commented 8 years ago

alright. we're good. can you commit your changes to github, after having pulled from dev as he made note of yesterday? I'd add yesterday's CSS as well and then i think we're good to go.

On Thu, Apr 28, 2016 at 11:04 AM, cee notifications@github.com wrote:

i notice no change here (so still looks good)

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/115#issuecomment-215512649

vitamincee commented 8 years ago

committed to develop branch. i didn't commit yest because i wasn't sure what branch y'all were working on. we should be all set now.

amandablum commented 8 years ago

hair flip hands up.

On Thu, Apr 28, 2016 at 11:36 AM, cee notifications@github.com wrote:

committed

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/115#issuecomment-215522031