amandablum / mindup

1 stars 0 forks source link

Add promoted post to popular tab on news sidebar. #116

Closed amandablum closed 8 years ago

amandablum commented 8 years ago

this is a new client request, so I just need an estimate of hours so she can approve. She's like to be able to promote one item at the top of the news sidebar and color it differently- throw a color BG on it or something. Functionality is up to you, makes sense to use sticky posts here. Talk to me about whether it would be easy or very difficult to just pull FIRST sticky post into the promoted slot. 2016-04-22_0752

chuckreynolds commented 8 years ago

No idea. i just posted a quick support ticket with that plugin dev; see what he says. kind of defeats the point for "popular" posts lol

amandablum commented 8 years ago

agreed... but she can't be talked down.

amandablum commented 8 years ago

any update on this

chuckreynolds commented 8 years ago

i wasn't told to do it. dev mentioned some code in the support request but I have no clue if it will work or how to implement it. if i had to guess on hours.. at least 3. and i can't do it tonight.

amandablum commented 8 years ago

Just needed to know it was possible.

On Thu, Apr 28, 2016 at 8:25 PM, Chuck Reynolds notifications@github.com wrote:

i wasn't told to do it. dev mentioned some code in the support request but I have no clue if it will work or how to implement it. if i had to guess on hours.. at least 3. and i can't do it tonight.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-215618335

amandablum commented 8 years ago

This has been approved at 4 hours. Can you just advise on WHEN you can get to it? I know its not this weekend.

chuckreynolds commented 8 years ago

well... anything's possible but. here's his response for reference: https://wordpress.org/support/topic/sticky-post-have-priority-at-top

amandablum commented 8 years ago

well. want me to just sponsor the dev from him, or you want a crack at it?

On Thu, Apr 28, 2016 at 8:52 PM, Chuck Reynolds notifications@github.com wrote:

well... anything's possible but. here's his response for reference: https://wordpress.org/support/topic/sticky-post-have-priority-at-top

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-215620560

chuckreynolds commented 8 years ago

he probably won't do it but I can take a crack at it tomorrow. it's basically rewriting his plugin front-end logic lol.

On Thursday, April 28, 2016, Amanda Blum notifications@github.com wrote:

well. want me to just sponsor the dev from him, or you want a crack at it?

On Thu, Apr 28, 2016 at 8:52 PM, Chuck Reynolds <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

well... anything's possible but. here's his response for reference: https://wordpress.org/support/topic/sticky-post-have-priority-at-top

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-215620560

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-215621231


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

amandablum commented 8 years ago

are we seeing the same thing? he's giving you a blueprint and then saying he'd help you.

A

On Thu, Apr 28, 2016 at 9:02 PM, Chuck Reynolds notifications@github.com wrote:

he probably won't do it but I can take a crack at it tomorrow. it's basically rewriting his plugin front-end logic lol.

On Thursday, April 28, 2016, Amanda Blum notifications@github.com wrote:

well. want me to just sponsor the dev from him, or you want a crack at it?

On Thu, Apr 28, 2016 at 8:52 PM, Chuck Reynolds < notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

well... anything's possible but. here's his response for reference: https://wordpress.org/support/topic/sticky-post-have-priority-at-top

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub < https://github.com/amandablum/mindup/issues/116#issuecomment-215620560>

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-215621231


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-215621420

chuckreynolds commented 8 years ago

"blueprint". yup I'll look at it tomm. or if you want to hire him to write a function to extend his plugin that's totally fine with me too. :)

On Thursday, April 28, 2016, Amanda Blum notifications@github.com wrote:

are we seeing the same thing? he's giving you a blueprint and then saying he'd help you.

A

On Thu, Apr 28, 2016 at 9:02 PM, Chuck Reynolds <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

he probably won't do it but I can take a crack at it tomorrow. it's basically rewriting his plugin front-end logic lol.

On Thursday, April 28, 2016, Amanda Blum <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

well. want me to just sponsor the dev from him, or you want a crack at it?

On Thu, Apr 28, 2016 at 8:52 PM, Chuck Reynolds < notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com'); <javascript:_e(%7B%7D,'cvml','notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');');>> wrote:

well... anything's possible but. here's his response for reference: https://wordpress.org/support/topic/sticky-post-have-priority-at-top

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub < https://github.com/amandablum/mindup/issues/116#issuecomment-215620560>

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub < https://github.com/amandablum/mindup/issues/116#issuecomment-215621231>


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-215621420

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-215622088


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

chuckreynolds commented 8 years ago

I'll comment back on that thread when I get home later. he should just allow stickies and doable that let of the query but allow that option in the template code that he already allows. good idea for that okigin actaillky.

On Thursday, April 28, 2016, Chuck Reynolds chuck@vuurr.com wrote:

"blueprint". yup I'll look at it tomm. or if you want to hire him to write a function to extend his plugin that's totally fine with me too. :)

On Thursday, April 28, 2016, Amanda Blum <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

are we seeing the same thing? he's giving you a blueprint and then saying he'd help you.

A

On Thu, Apr 28, 2016 at 9:02 PM, Chuck Reynolds <notifications@github.com

wrote:

he probably won't do it but I can take a crack at it tomorrow. it's basically rewriting his plugin front-end logic lol.

On Thursday, April 28, 2016, Amanda Blum notifications@github.com wrote:

well. want me to just sponsor the dev from him, or you want a crack at it?

On Thu, Apr 28, 2016 at 8:52 PM, Chuck Reynolds < notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

well... anything's possible but. here's his response for reference:

https://wordpress.org/support/topic/sticky-post-have-priority-at-top

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub < https://github.com/amandablum/mindup/issues/116#issuecomment-215620560>

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub < https://github.com/amandablum/mindup/issues/116#issuecomment-215621231>


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub <https://github.com/amandablum/mindup/issues/116#issuecomment-215621420

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-215622088


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

amandablum commented 8 years ago

ok. I leave this at your discretion. You are my first choice, but if you'd rather, i'll ask him. In either case, I'm cool contributing the code back to him. I'm unleashing the site on the client today, but I'm also backing up right now.

chuckreynolds commented 8 years ago

Okay.

mindup-popular-override

chuckreynolds commented 8 years ago

oops. lol.. I forgot to deploy it. ugh i need sleep. committing now and it'll auto-deploy in 10..9..8..

chuckreynolds commented 8 years ago

also FYI. I bumped internal theme version to 1.0.0. If everything is approved I'll bundle this, merge to master and tag for release. cc @amandablum

amandablum commented 8 years ago

Hey. passes Q/A. question: how intensive would it be to remove the promoted post from the popular leaderboard? If I set video 2 to promoted, it shows up on list 2x, since its also popular.

Just estimate it, not sure its worth it.

chuckreynolds commented 8 years ago

yeah interesting... 30min... done. committing to repo -> auto deploy.

chuckreynolds commented 8 years ago

actually.... so what I did was remove the sticky posts from the popular list completely. What I maybe should do.... is since we're only showing ONE Sticky..... if they have other stickies allow those to show in the WPP list unless it's the most recent one... because that's the only one that'll show up on the top.

savvy? (note: this is the problem with people using sticky posts lol - they never UNsticky them)

amandablum commented 8 years ago

agreed on all On May 27, 2016 4:58 PM, "Chuck Reynolds" notifications@github.com wrote:

actually.... so what I did was remove the sticky posts from the popular list completely. What I maybe should do.... is since we're only showing ONE Sticky..... if they have other stickies allow those to show in the WPP list unless it's the most recent one... because that's the only one that'll show up on the top.

savvy? (note: this is the problem with people using sticky posts lol - they never UNsticky them)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/amandablum/mindup/issues/116#issuecomment-222276989, or mute the thread https://github.com/notifications/unsubscribe/ACQcIzVZEhIH4NNy0u1NLdtdHVNtbiN5ks5qF4UlgaJpZM4INrt_ .

chuckreynolds commented 8 years ago

okay. done.

amandablum commented 8 years ago

and it works except that if you don't have any sticky posts, it runs an error. 2016-05-27_1833

chuckreynolds commented 8 years ago

fuck. that's weird. I'll get it tomorrow.


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

chuckreynolds commented 8 years ago

fixed.

amandablum commented 8 years ago

Hey, functionality works perfectly. Up above, you'd noted that you'd done a callout, I assumed this was in the CSS so I could target it. I just want to change the BG on the promoted post title to #F3A129

chuckreynolds commented 8 years ago

data attribute is "data-wppcount="sticky"" So CSS is something like

h4[data-wppcount="sticky"] {
  background-color: #f3a129;
}