amandablum / mindup

1 stars 0 forks source link

archives/repo first post need formatting for mobile. #118

Closed amandablum closed 8 years ago

amandablum commented 8 years ago

the featured posts on all archives and repo disappear on mobile because that div is set to display:none. Needs formatting. http://mindup.vuurrclients.com/repo/ http://mindup.vuurrclients.com/category/videos/ http://mindup.vuurrclients.com/category/webinars/ etc.

vitamincee commented 8 years ago

Sorry about that! Here's the code which needs to be changed:

DELETE:

.three-hero-posts, .hero-post { display: none; }

ADD THIS in it's place:

    .three-hero-posts .hero-one {
            width: 100%;
    }

    .three-hero-posts .hero-two,
    .three-hero-posts .hero-three {
            margin-top: 40px;
            width: 48%;
            float: left;
    }

    .three-hero-posts .hero-two {
            padding-right: 2%;
    }

    .three-hero-posts .hero-three {
            padding-left: 2%;
    }

and then inside the query @media (max-width: 767px) { }, right below this bit:

    body.blog #primary,
    body.page-template-tpl-repo #primary {
            padding-left: 0;
            border-left: 0;
    }

ADD the following:

    .three-hero-posts {
            border: 0;
            margin: 0;
    }

    .three-hero-posts .hero-one {
            width: 100%;
            padding-right: 0;
            float: none;
    }

    .three-hero-posts article {
            clear: both;
            border-bottom: 2px solid #e1e1e1;
            padding-bottom: 15px !important;
            margin-bottom: 20px !important;
    }

    .three-hero-posts article h2.entry-title,
    .three-hero-posts .hero-one h2 {
            font-size: 1.5rem;
    }

    .three-hero-posts .hero-two,
    .three-hero-posts .hero-three {
            margin-top: 5px !important;
            width: 100% !important;
            float: none !important;
            padding: 0 !Important;
    }
amandablum commented 8 years ago

@chuckreynolds can you handle above. thx.

chuckreynolds commented 8 years ago

yeah prob tonight at some point or early tomorrow.

On Wednesday, April 27, 2016, Amanda Blum notifications@github.com wrote:

@chuckreynolds https://github.com/chuckreynolds can you handle above. thx.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/118#issuecomment-215272624


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

amandablum commented 8 years ago

I did it already. committed on Cee's branch. FUCK YOU GIT I HAVE CONQUERED LESSER EVILS THAN YOU.

Wheres my gddamn whiskey.

On Wed, Apr 27, 2016 at 5:41 PM, Chuck Reynolds notifications@github.com wrote:

yeah prob tonight at some point or early tomorrow.

On Wednesday, April 27, 2016, Amanda Blum notifications@github.com wrote:

@chuckreynolds https://github.com/chuckreynolds can you handle above. thx.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/118#issuecomment-215272624


@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/118#issuecomment-215274204

chuckreynolds commented 8 years ago

okay. that was the wrong and old branch and you didn't merge develop (all the new stuff) into branch: cee before adding new commit. I'm cleaning it up and getting it all setup right.

Also for reference any !important flag in css shouldn't be capital I, always lowercase in css.

Another thing... if you run this through http://csslint.net there are a few duplicates and issues but i'm not messing with those tonight. Standby for updates. You guys need to checkout of develop branch and pull.

chuckreynolds commented 8 years ago

Repo is bugged. @vitamincee on your local just checkout the develop branch and pull. That'll put you on the current branch and we can all go from there. 👍

vitamincee commented 8 years ago

Thanks for adding this Chuck!

While that !Important was a typo, CSS is case insensitive, so it would still work fine. The only things that you have to worry about with case are classes/ids.

chuckreynolds commented 8 years ago

CSS is case insensitive, so it would still work fine

kk... my linter in sublimetext did NOT like it lol.. either did csslint but g2k.

I still see an issue with full-size desktop on http://mindup.vuurrclients.com/repo/ Thoughts there? something obviously got messed in that 'patch' job. If you can push the fixes i think everything is done?

amandablum commented 8 years ago

chuck, what are you seeing?

On Thu, Apr 28, 2016 at 12:35 PM, Chuck Reynolds notifications@github.com wrote:

CSS is case insensitive, so it would still work fine kk... my linter in sublimetext did NOT like it lol.. either did csslint but g2k.

I still see an issue with full-size desktop on http://mindup.vuurrclients.com/repo/ Thoughts there? something obviously got messed in that 'patch' job. If you can push the fixes i think everything is done?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/118#issuecomment-215538425

chuckreynolds commented 8 years ago

screen shot 2016-04-28 at 14 03 01

amandablum commented 8 years ago

confirmed.

On Thu, Apr 28, 2016 at 2:03 PM, Chuck Reynolds notifications@github.com wrote:

[image: screen shot 2016-04-28 at 14 03 01] https://cloud.githubusercontent.com/assets/46185/14901397/f044ef7e-0d49-11e6-85cb-e3dcadbeadea.png

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/118#issuecomment-215561701

vitamincee commented 8 years ago

the code was pasted into the wrong breakpoint - i moved it to the right spot and committed.

chuckreynolds commented 8 years ago

HI-FIVE. there we go 👍

amandablum commented 8 years ago

excellent!!!

On Thu, Apr 28, 2016 at 3:14 PM, Chuck Reynolds notifications@github.com wrote:

HI-FIVE. there we go 👍

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/118#issuecomment-215578860