search

amandablum / mindup

1 stars 0 forks source link

repo now has wrong sidebar. #121

Closed amandablum closed 8 years ago

amandablum commented 8 years ago

its pulling the default sidebar, not the popular/recent posts sidebar.

chuckreynolds commented 8 years ago

so technically the /repo has always had this sidebar in dev. the code hasn't ever changed. so you want the sidebar logic to be TRUE if page is /repo/ now?

amandablum commented 8 years ago

If it has in dev, I wasn't paying attention. It was not in Cee's staging. http://dev1.dapperdigital.net/repo/

Yes, please ensure this pop/recent sidebar shows on repo, and any single page. It should not show on archives.

On Thu, Apr 28, 2016 at 8:34 PM, Chuck Reynolds notifications@github.com wrote:

so technically the /repo has always had this sidebar in dev. the code hasn't ever changed. so you want the sidebar logic to be TRUE if page is /repo/ now?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/121#issuecomment-215619018

chuckreynolds commented 8 years ago

well repo was set to is_home, hasn't been here. see question i had the other day. okay. i'll fix.

Now too the popular post sidebar should NOT show on archive?

amandablum commented 8 years ago

it NEVER showed on archives. http://mindup.vuurrclients.com/category/news/ http://mindup.vuurrclients.com/category/white-papers/

On Thu, Apr 28, 2016 at 8:37 PM, Chuck Reynolds notifications@github.com wrote:

well repo was set to is_home, hasn't been here. see question i had the other day. okay. i'll fix.

Now too the popular post sidebar should NOT show on archive?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/121#issuecomment-215619262

amandablum commented 8 years ago

and should not

On Thu, Apr 28, 2016 at 8:38 PM, Amanda Blum - Howling Zoe Productions < amanda@howlingzoe.com> wrote:

it NEVER showed on archives. http://mindup.vuurrclients.com/category/news/ http://mindup.vuurrclients.com/category/white-papers/

On Thu, Apr 28, 2016 at 8:37 PM, Chuck Reynolds notifications@github.com wrote:

well repo was set to is_home, hasn't been here. see question i had the other day. okay. i'll fix.

Now too the popular post sidebar should NOT show on archive?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/121#issuecomment-215619262

chuckreynolds commented 8 years ago

ok. code is in there for it to display on archive but there's no actual sidebar called in archive. got it. confusing. fixing that extra logic in sidebar.