search

amandablum / mindup

1 stars 0 forks source link

pop/latest sidebar should not show on single products #124

Closed amandablum closed 8 years ago

amandablum commented 8 years ago

single-product.php needs to be added to the logic for the sidebar. it should NOT show on single-product.php but should show on single.php.

chuckreynolds commented 8 years ago

EDIT... okay i see this is related to #123 - there is no file that does such a thing... i'm assuming i need to read woocomm docs to see how they handle it?

amandablum commented 8 years ago

the basic plugin contains theme files for products, etc. youll find the single_product.php there . On Apr 29, 2016 3:15 PM, "Chuck Reynolds" notifications@github.com wrote:

EDIT... okay i see this is related to #123 https://github.com/amandablum/mindup/issues/123 - there is no file that does such a thing... i'm assuming i need to read woocomm docs to see how they handle it?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/124#issuecomment-215895957

chuckreynolds commented 8 years ago

so i add it to root of the theme and the plugin overrides the plugin version? trying to find docs.

amandablum commented 8 years ago

add it to the root of the theme and it will override the plugin version. works like a child theme. https://docs.woothemes.com/document/third-party-custom-theme-compatibility/

On Fri, Apr 29, 2016 at 3:20 PM, Chuck Reynolds notifications@github.com wrote:

so i add it to root of the theme and the plugin overrides the plugin version? trying to find docs.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/124#issuecomment-215896701

chuckreynolds commented 8 years ago

ya that still won't work cause it's not a page template. i found something that should work but i don't have woocomm locally so can't test. uploading momentarily. standby

amandablum commented 8 years ago

cool. thanks, and sorry for throwing the wrench late in the game.

On Fri, Apr 29, 2016 at 3:25 PM, Chuck Reynolds notifications@github.com wrote:

ya that still won't work cause it's not a page template. i found something that should work but i don't have woocomm locally so can't test. uploading momentarily. standby

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/124#issuecomment-215897450

chuckreynolds commented 8 years ago

i have a toolbox full of wrenches. lmk if that worked. :)

amandablum commented 8 years ago

sadly, no. http://mindup.vuurrclients.com/product/donation-to-the-hawn-foundation/ <- this is the only product.but its still got the sidebar.

On Fri, Apr 29, 2016 at 3:27 PM, Chuck Reynolds notifications@github.com wrote:

i have a toolbox full of wrenches. lmk if that worked. :)

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/124#issuecomment-215897786

chuckreynolds commented 8 years ago

okay. now that i know woocomm just uses is_single for is_product... there we go. fixed.

chuckreynolds commented 8 years ago

FUUUUUUCK. ugh. .. bugs cause non-woocomm throws error. one min...

chuckreynolds commented 8 years ago

okay fixed. added a safety on that so if woocomm doesn't exist (isn't active) it won't error out.