search

amandablum / mindup

1 stars 0 forks source link

uncenter centered copy #127

Closed amandablum closed 8 years ago

amandablum commented 8 years ago

because ours is not to ask why, just to do. they only want the paragraphs (open text) left aligned. headers, etc should stay centered. they wanted to bump text size up by 1. I think this solves that. .centeredcopy p { text-align: left; font-size: 110%; }

amandablum commented 8 years ago

now everything is centered. they just wanted the p centered. which is why this works: .centeredcopy p { text-align: left; font-size: 1.1em; }

amandablum commented 8 years ago

definitely getting closer. header centered (good) copy left aligned (good), button left aligned (bad). example here: http://mindup.vuurrclients.com/

chuckreynolds commented 8 years ago

your button is in the p you just wanted left-aligned

amandablum commented 8 years ago

yeah. i realized that when I went to test it. didn't realize it was wrapping everything in p's. my bad.

On Mon, May 23, 2016 at 6:12 PM, Chuck Reynolds notifications@github.com wrote:

your button is in the p you just wanted left-aligned

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/127#issuecomment-221140418

chuckreynolds commented 8 years ago

i'll have to change this to put it into its own div... idk what css will do but i'll do all that tonight. 

if ( $centered_cta_copy && $centered_cta_link ) : ?>
    <p><a href="<?php echo $centered_cta_link; ?>" class="btn"><?php echo $centered_cta_copy; ?></a></p>
<?php
endif;
amandablum commented 8 years ago

cool. thanks.

On Mon, May 23, 2016 at 6:14 PM, Chuck Reynolds notifications@github.com wrote:

i'll have to change this to put it into its own div... idk what css will do but i'll do all that tonight.

if ( $centered_cta_copy && $centered_cta_link ) : ?>

amandablum commented 8 years ago

couldn't you just pull the p wrapper off the button? i thought WP was inserting it automatically, I didn't realize you'd coded it in.

A

On Mon, May 23, 2016 at 6:15 PM, Amanda Blum - Howling Zoe Productions < amanda@howlingzoe.com> wrote:

cool. thanks.

On Mon, May 23, 2016 at 6:14 PM, Chuck Reynolds notifications@github.com wrote:

i'll have to change this to put it into its own div... idk what css will do but i'll do all that tonight.

if ( $centered_cta_copy && $centered_cta_link ) : ?>

chuckreynolds commented 8 years ago

ya. just had to make sure the button class wasn't inside the p declaration. pushing now.