svg support

[amandablum]

Have tried to get svg support via plugins, doesn't seem to work. svgs can be uploaded to media library, but won't attach to ACF and there's a CSS problem on the other side of ACF as well for the constellation using them.

• [ ] add upload support for SVG (done by plugin, perhaps should be redone via functions)
• [ ] allow svgs to attach to ACF wherever images can be uploaded (1 col, 2 col, constellation are bigger use case)
• [ ] ideally, allow svgs to be previewed in media uploader (less important)

Jim Jeffers worked on the js for the constellation, so he'd likely be the person to write any support code for SVGs thats needed there.

It seems the svg can be a security risk, so wondering if any of your security precautions like stripped HTML etc are blocking the plugins from working? SVG Support is currently activated.

[chuckreynolds]

first off this isn't a bug - it's a feature request. second... i see you put on "svg-support" plugin... did you add the class name to the images as the plugin suggests? http://mindup.vuurrclients.com/wp-admin/options-general.php?page=svg-support

[amandablum]

since it was always supposed to support SVGs, wouldn't that be a bug? If I was requesting it for the first time, it would be a feature.

Did not add class name, since I don't have access to that:) Also, exporting new svgs because I want to ensure the issue isn't bad client svgs.

On Tue, May 31, 2016 at 9:56 PM, Chuck Reynolds notifications@github.com wrote:

first off this isn't a bug - it's a feature request. second... i see you put on "svg-support" plugin... did you add the class name to the images as the plugin suggests? http://mindup.vuurrclients.com/wp-admin/options-general.php?page=svg-support

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amandablum/mindup/issues/136#issuecomment-222892603, or mute the thread https://github.com/notifications/unsubscribe/ACQcIzVR8-cFsekucYKIGNV57hgROJhBks5qHRD4gaJpZM4Iq1-N .

[chuckreynolds]

Well it's news to me.

So... what fields do you want svgs on? and how am I supposed to know if they add an svg or a png or a jpg to said field. Don't see much in ACF docs on G-search about it...

[amandablum]

well. what i'm finding is that if I'm understanding this, it was an issue they patched and now its back. https://support.advancedcustomfields.com/forums/topic/svg-images-not-attaching/

The major fields are constellation image upload, 2 column image upload and one column image upload, in that priority. for infographics and icons, they'd be pretty important.

On Tue, May 31, 2016 at 10:11 PM, Chuck Reynolds notifications@github.com wrote:

Well it's news to me.

So... what fields do you want svgs on? and how am I supposed to know if they add an svg or a png or a jpg to said field. Don't see much in ACF docs on G-search about it...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amandablum/mindup/issues/136#issuecomment-222894352, or mute the thread https://github.com/notifications/unsubscribe/ACQcI00GU3bY8eFOvuXrasIipThp1ItUks5qHRSUgaJpZM4Iq1-N .

[chuckreynolds]

so your

you look here: http://mindup.vuurrclients.com/pagebuilder/ those are all svgs. worked fine in testing. something has happened to make it not work now.

only thing that changed since long ago in code is the popular post queries... nothing else was touched. Could be a settings issue with the plugins that changed? i haven't been in admin

[amandablum]

I've spent the day noodling around trying to figure out why things aren't working. there are a lot of things at play- are the client svgs shit or good (i think i'm learning they're crap, i'm uploading new ones). I eliminated it being the front end code. I've eliminated it being WordPress, it was always allowing those uploads. So I think its just ACF. And we might not be able to fix it.

what I think i've figured out is that they will upload ok to media library and acf, but acf will not allow them to attach. so you upload them, they work, but if you go back to the backend, it looks like the image isn't attached. I'd like to say I checked this previously, but once I checked the page and saw the svgs were working, its unlikely I went back and checked that they were attached. I deactivated plugins all day to check, didn't change anything. I suspect it always worked this way.

On Tue, May 31, 2016 at 10:14 PM, Chuck Reynolds notifications@github.com wrote:

so your

you look here: http://mindup.vuurrclients.com/pagebuilder/ those are all svgs. worked fine in testing. something has happened to make it not work now.

only thing that changed since long ago in code is the popular post queries... nothing else was touched. Could be a settings issue with the plugins that changed? i haven't been in admin

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amandablum/mindup/issues/136#issuecomment-222894732, or mute the thread https://github.com/notifications/unsubscribe/ACQcIwAt5hbLcR5YDIIcD0pSGizs8Kcpks5qHRVAgaJpZM4Iq1-N .

[chuckreynolds]

so they're just not displaying in the admin when editing?

[chuckreynolds]

I turned on debug and query-monitor - see if that page that you add/view svg's on is throwing errors.

also coschedule has issues in admin. fyi

[amandablum]

1. upload svg to an image field. hit save.

1. the front end will show the svg, but the backend will look as if you never attached an image there.
2. if you try to reattach, it won't find the svg in the media library, even though its there.

[chuckreynolds]

so i don't have an svg to test but that's easily an ACF issue. Can you link me to that admin page? Did you see any bugs in the debug bar?

[amandablum]

emailing svg

http://mindup.vuurrclients.com/wp-admin/post.php?post=912&action=edit

i don't see any errors while uploading.

[chuckreynolds]

So I created one in Sketch... uploaded it... goes up fine... shows as attached and after you save it doesn't show it as attached or referenced to the post. It's an ACF issue and I don't see any errors being produced. You need to file a bug with them. Make sure you tell them the type of field it is, that it's in tabs, etc etc etc.

[amandablum]

from ACF: "Please keep in mind that WordPress doesn't allow you to upload SVG images in the first place. It seems that you used a custom function to allow it. Could you please try the code on this page instead: https://www.leighton.com/blog/enable-upload-of-svg-to-wordpress-media-library?"

you'l find this in the latest commit to amandaedits branch.

[chuckreynolds]

still sitting in an airport delayed. can get this in couple hours when I land and reach useable wifi

---

@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

[amandablum]

cool thanks.

On Fri, Jun 3, 2016 at 11:16 AM, Chuck Reynolds notifications@github.com wrote:

still sitting in an airport delayed. can get this in couple hours when I land and reach useable wifi

---

@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amandablum/mindup/issues/136#issuecomment-223653425, or mute the thread https://github.com/notifications/unsubscribe/ACQcI799Kr8DL6HbPva5Vdtt5fgRVDEaks5qIG9zgaJpZM4Iq1-N .

[amandablum]

going to do the thing you hate and update via dashboard editor. either it works and you upload theme later which changes nothing or it doesn't work, you overwrite functions to revert back to before I did this (last 7 lines of functions file) later.

and yes, i can feel the searing heat of your angry focus from PDX:)

On Fri, Jun 3, 2016 at 11:18 AM, Amanda Blum - Howling Zoe Productions < amanda@howlingzoe.com> wrote:

cool thanks.

On Fri, Jun 3, 2016 at 11:16 AM, Chuck Reynolds notifications@github.com wrote:

still sitting in an airport delayed. can get this in couple hours when I land and reach useable wifi

---

@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amandablum/mindup/issues/136#issuecomment-223653425, or mute the thread https://github.com/notifications/unsubscribe/ACQcI799Kr8DL6HbPva5Vdtt5fgRVDEaks5qIG9zgaJpZM4Iq1-N .

[amandablum]

updated via dashboard editor (sorry!). Solves issue. Will be overwritten by your update later which is great.

[amandablum]

worked! commit should overwrite this and all should be good. fixed issue altogether.

On Fri, Jun 3, 2016 at 11:22 AM, Amanda Blum - Howling Zoe Productions < amanda@howlingzoe.com> wrote:

going to do the thing you hate and update via dashboard editor. either it works and you upload theme later which changes nothing or it doesn't work, you overwrite functions to revert back to before I did this (last 7 lines of functions file) later.

and yes, i can feel the searing heat of your angry focus from PDX:)

On Fri, Jun 3, 2016 at 11:18 AM, Amanda Blum - Howling Zoe Productions < amanda@howlingzoe.com> wrote:

cool thanks.

On Fri, Jun 3, 2016 at 11:16 AM, Chuck Reynolds <notifications@github.com

wrote:

still sitting in an airport delayed. can get this in couple hours when I land and reach useable wifi

---

@ChuckReynolds | Vuurr http://vuurr.com http://linkedin.com/in/chuckreynolds

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amandablum/mindup/issues/136#issuecomment-223653425, or mute the thread https://github.com/notifications/unsubscribe/ACQcI799Kr8DL6HbPva5Vdtt5fgRVDEaks5qIG9zgaJpZM4Iq1-N .

[amandablum]

closed accidentally. This is the issue I was saying I'd edited in.