amandablum / mindup

1 stars 0 forks source link

some acf header tags are <p> tags instead of <h2> or <h1> #7

Closed vitamincee closed 8 years ago

vitamincee commented 8 years ago
Some headers are being wrapped in <p> tags instead of <h1> or <h2> tags, for example:

centeredcopy 
"H2 header goes here and two lines is the max space. 68 char" 
should be <h2>

3column
"Header Style 3 2 Line Max"
guessing this should be <h3>

1columnhero
"Your Brain is Command Central"
guessing this should be <h1> or <h2>

Unsure if this is something I can change myself?
chuckreynolds commented 8 years ago

Like I said at the beginning - I'm just going to put stuff in basic divs and p wrappers. Even if I put them in H* tags I'd assume you'd change those to whatever the layout required. I just dumped the metadata into a basic layout. You change the html to what it needs to be to fit your layout. All the vars are there, just move them where you need them.

amandablum commented 8 years ago

its in each individual file such as >acf-1columnhero.php

vitamincee commented 8 years ago

thank you for answering my question @amandablum

chuckreynolds commented 8 years ago

I thought the email mindup acf brief covered that fairly well?