search

amandablum / mindup

1 stars 0 forks source link

[mobile] news sidebar - search bar relocation #75

Closed amandablum closed 8 years ago

amandablum commented 8 years ago

the bottom rule is going to be removed under the last post related to #49 ... but that rule should go under the page numbers. also, the search, per the comp, should be above the post, not in the sidebar. this is only in xsmall/small. actual: 2016-04-04_0913

comp: 2016-04-04_0913_001

comp: 2016-04-04_0914

vitamincee commented 8 years ago

unsure how to get search to show up above content when it's being called from the sidebar file, unless I call it twice and hide it / show it with css which seems kinda hacky.

amandablum commented 8 years ago

lets kick this one to chuck.

chuckreynolds commented 8 years ago
  1. it's not a bug - it's just how responsive architecture works.

Option A: Do what Cee suggested and have a search field above archive content only visible on mobile. Option B: We load a mobile detection library and include the search where desired if library designates view is mobile device. (won't work when testing on desktop and making window small)

amandablum commented 8 years ago

Option A.

On Fri, Apr 15, 2016 at 2:39 PM, Chuck Reynolds notifications@github.com wrote:

  1. it's not a bug - it's just how responsive architecture works. Option A: Do what Cee suggested and have a search field above archive content only visible on mobile. Option B: We load a mobile detection library and include the search where desired if library designates view is mobile device. (won't work when testing on desktop and making window small)

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/75#issuecomment-210657764

chuckreynolds commented 8 years ago

kk

amandablum commented 8 years ago

We should also make the original search box go away (is this just a display:none situation?) at the same breakpoints the new search box becomes visible.

On Fri, Apr 15, 2016 at 2:45 PM, Chuck Reynolds notifications@github.com wrote:

kk

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/75#issuecomment-210659172

chuckreynolds commented 8 years ago

yup i know

amandablum commented 8 years ago

Most of the time I open my mouth its just to hear myself speak.

On Fri, Apr 15, 2016 at 2:51 PM, Chuck Reynolds notifications@github.com wrote:

yup i know

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/amandablum/mindup/issues/75#issuecomment-210660397

chuckreynolds commented 8 years ago

yup i know

amandablum commented 8 years ago

testing across android devices. based on note above, didn't bother w emulator. will hit device lab later today, so leaving open until then, but consider this approved.