4.5 removes some deprecated messaging constants, causes install error

amandadoughty / moodle-mod_peerwork

5 stars 8 forks source link

4.5 removes some deprecated messaging constants, causes install error #25

Closed davidscotson closed 2 weeks ago

davidscotson commented 1 month ago

I got an install error:

Exception - Undefined constant "MESSAGEDEFAULT
LOGGEDIN" Debug:
Error code: generalexceptionmessage

line 32 of /mod/peerwork/db/messages.php: Error thrown

when running a github actions workflow on the new MOODLE_405_STABLE branch

https://github.com/davidscotson/moodle-mod_peerwork/actions/runs/11236764479/job/31237609273

davidscotson commented 1 month ago

I've replaced these with MESSAGE_DEFAULT_ENABLED which seems to be the standard replacement for MESSAGE_DEFAULT_LOGGEDIN + MESSAGE_DEFAULT_LOGGEDOFF

But I couldn't find an example where the existing code had only MESSAGE_DEFAULT_LOGGEDOFF so that might be a mild, unavoidable?, change in behaviour.

https://github.com/davidscotson/moodle-mod_peerwork/commit/09b05e9be001c0aa113a726acc641f66a93bd5d4

These changes might require an update to a Moodle 4.0+ dependency.