search

amandaghassaei / Fusion360-Scripts

A collection of Fusion360 scripts, mostly for generating animations
MIT License
108 stars 12 forks source link

"Design history animation" rotates about wrong axis #7

Open positron96 opened 11 months ago

positron96 commented 11 months ago

Hello and thank you for an excellent plugin! I am trying out Design history animation add-in, and it seems to rotate the camera in vertical plane, not horizontal. Maybe the axes in my project are not default (my vertical axis is Z and frontal plane is XZ)

FutureJames commented 5 months ago

Similar issue. I see that in the docs it references "y-axis" being the default vertical for Fusion360, but I have only ever seen it set to "z-axis". Historically, many 3d editors use Y as vertical (Maya, 3DSMax, Unity), while others use Z as vertical (Unreal, Blender, Fusion360). Given that there are several great looking animations in the README for this repo, I assume there is something I am missing. That being said, I have updated the script to just allow the user to select X, Y, or Z for the axis of rotation. I will submit a PR if that is welcomed. Either way, great script functionality. thanks for sharing your work!

(edit) Never mind. Looks like someone already submitted a PR :)

amandaghassaei commented 5 months ago

thanks for bringing this to my attention, it looks like the current pr is for the spin animation only. Would you mind submitting a pr for the design history animation? happy to merge it in, just don't have the time to write it myself!

amandaghassaei commented 5 months ago

I've just merged the other pr btw.

FutureJames commented 5 months ago

Cool, I will give things a once over and do a little more testing and submit a PR. I am also working on a refactor that takes a lot of your ideas and consolidates them into a single tool, while updating to fix a few bugs and deprecated APIs. I kind of just made it to suit my own uses cases, but I'd be happy to submit it back here as well if you'd like. Either way, I have you credited in the docs and comments.

amandaghassaei commented 5 months ago

sounds good, happy to take a look. thanks!