amandasaurus / waterwaymap.org

WaterwayMap.org | River Basins from OpenStreetMap
https://WaterwayMap.org
Apache License 2.0
58 stars 12 forks source link

Exclude waterway=pressurised from Natural Waterways overlay #47

Closed hungerburg closed 6 months ago

hungerburg commented 6 months ago

I see them a lot here, I am in the Alps, hydropower galore! They also connect across watersheds so false basin assigned.

flacombe commented 4 months ago

Hello @amandasaurus

Despite waterway=pressurised aren't natural waterways, water does flow through them. Sometimes they divert significant amount of water from natural courses

flowing_water.tagfilterfunc sounds to detect flowing water, not only natural courses, aren't you?

amandasaurus commented 4 months ago

Yes it should detect flowing water. But if it's being pressurised, then the water is being (artificially) pushed somewhere. I want to map "naturally flowing water". Do you have an example of an OSM way which is tagged like this and is naturally flowing? Is there another tag combination that we can look at?

hungerburg commented 4 months ago

Perhaps the question is, why flagging them in this filter does not hide them from the flowing water plot, but only from the natural water plot?

PS: In Austria there are 522 pressurized waterways. 502 of them are pipelines, the rest flooded tunnels. Certainly, in all of them water flows the natural direction indicated by gravity, i.e. from top to bottom, most of the time. Very few go to pump-storage and are artificially pushed, in the strictest sense ;) They some times change direction. There are even times, when the water does not flow, this can happen to all of them, e.g. when there is enough power on the market.

amandasaurus commented 4 months ago

OK, now I'm confused. 😅🤔.

If the water in waterway=pressurised is free flowing, then it should be included in flowingwater.

Yes, it might join up river basins, but (i) that happens anyway with natural river bifurations (ii) I have a solution for that 🤫

flacombe commented 4 months ago

Hello all

I want to map "naturally flowing water".

Well, I know it looks simpler but it actually doesn't.
Hydrography connectivity as pursued by waterwaymap needs both natural and artificial flows.

This table classifies natural/artificial versus free/pipe flows: https://wiki.openstreetmap.org/wiki/Key:waterway#Values We currently miss natural pipe flow value(s) but it actually exists: caves which are constantly underwater (inverted siphons). By the way, as @hungerburg, pressurised waterways don't need pumps to operate. The table is summarized here: https://wiki.openstreetmap.org/wiki/File:Waterway_flows.png

See this supplementary chart for most common situations: https://wiki.openstreetmap.org/wiki/File:Waterway_manmade_structures.png

If the water in waterway=pressurised is free flowing

Gravitational flow and free flow are different.
Free flow is flowing at atmospheric pressure, like a river.

Yes, it might join up river basins

It can not only joint up river basins but also divert water from natural course in the same basin, or connect two natural sections of a single river. Removing channelized sections may break up the same basin in two parts, like seen on #56

Hope it helps

hungerburg commented 4 months ago

1) For what I can tell: A waterway=pressurized must not be shown in the natural plane. It is only used on constructions for hydropower by the mapping few, at least in the area of my local knowledge. 2) I would not bet that if I jumped into a flooded tunnel (as mapped by the few) that I would always have air space, like the diagram purports. There is no need to insert a pipe to flood a tunnel to the brim.

We currently miss natural pipe flow value

I'd never tag a waterway=pressurized there - any examples in the wild? These certainly would be in need of a special tag, IMO.

BTW: The table picture does not show the most common (at least I suppose) use of penstock.

PS: In my area, between the headrace and the penstock there is a https://wiki.openstreetmap.org/wiki/Tag:pipeline%3Dsurge_tank - but I am reluctant to map that, because I am not that much of an expert.

flacombe commented 4 months ago

A waterway=pressurized must not be shown in the natural plane. It is only used on constructions for hydropower by the mapping few, at least in the area of my local knowledge.

You can't tell until you add some artificial structure containing it:

I would not bet that if I jumped into a flooded tunnel (as mapped by the few) that I would always have air space

tunnel=flooded is only intended to state the tunnel isn't designed to allow people to safely walk in operation. It doesn't assume the flowing regime, free or pipe flow. It can be combined both with waterway=canal or with waterway=pressurised.

I'd never tag a waterway=pressurized there - any examples in the wild? These certainly would be in need of a special tag, IMO.

Any cave where you dive in: https://timesofindia.indiatimes.com/travel/norway/plura-river-cave-diving/ps37309226.cms This is pipe flow.

The table picture does not show the most common (at least I suppose) use of penstock.

What should be shown according to you?

but I am reluctant to map that, because I am not that much of an expert.

This wiki may help you: https://wiki.openstreetmap.org/wiki/Power_generation/Hydropower#Surge_tanks

hungerburg commented 4 months ago

There is another picture of yours here https://wiki.openstreetmap.org/wiki/File:Waterways_millrace.png showing better what I think penstock is about. A similar graphic here page 10 https://www.ewa-services.at/files/broschuere_kw_kartell.pdf#page=10&zoom=page-fit,-2,760 - headrace pressurised up to the surge tank -- This one actually mapped -- The pipeline should be split there?

Any cave where you dive in

But how is it mapped? As a waterway=pressurized? I'd consider that wrong.

flacombe commented 4 months ago

There is another picture of yours here https://wiki.openstreetmap.org/wiki/File:Waterways_millrace.png

It's an extract from https://wiki.openstreetmap.org/wiki/File:Waterway_flows.png

A similar graphic here page 10 https://www.ewa-services.at/files/broschuere_kw_kartell.pdf#page=10&zoom=page-fit,-2,760

Headraces can be pressurised (with a surge tank at the connection with penstocks), like on the EWA services chart, or free flow (with a forebay at the connection with penstocks) like on my charts. It depends on many parameters but both are valid designs.

But how is it mapped? As a waterway=pressurized? I'd consider that wrong.

Currently we only have waterway=pressurised to describe pipe flow waterways. pressurised waterway only means it's a flow of water running with a static pressure > atmospheric pressure. It doesn't assume it's artificial, underground, concrete lined or whatever. Other tags are here to describe in which context it occurs.

It is intended for anyone who minds about water flows without bother about tunnels, caves, artificial or natural, underground or not, pumps... which is other tags' business.

hungerburg commented 4 months ago

@flacombe I guess I am starting to see. This is not about what the mapping community does. It is about your idea, how the tag could be used outside of the hydropower scheme.

In my opinion, the mapping community is right in not using the tag like this:

This would be akin to highway=bridge|tunnel, don't you think?

flacombe commented 4 months ago

how the tag could be used outside of the hydropower scheme.

The tag is not specific to hydropower.

In my opinion, the mapping community is right in not using the tag like this:

We're still looking for a better solution, 6 years and counting.

This would be akin to highway=bridge|tunnel, don't you think?

It's the strict opposite. waterway=pressurised doesn't assume its container.

hungerburg commented 4 months ago

The solution is as easy as tagging siphon=yes on a river or a stream. Much like we do with bridges or tunnels.

PS: I have tasked the community forum to shed more light on this, https://community.openstreetmap.org/t/rfc-deprecate-use-of-waterway-pressurised-on-anything-not-artificially-built-for-hydropower-uses/115222

flacombe commented 4 months ago

The solution is as easy as tagging siphon=yes on a river or a stream.

Unfortunately, rivers or streams are free flow and can't be used to describe pipe water flows.

That's why I suggest to integrate pressurised waterways into waterwaymap graph.

hungerburg commented 4 months ago

This got me a stream of 30+ e-mails. Following the talk, the gist of it to me: Natural non-artificial flows of water underground deserve one or more tags on their own yet to be found and not get filed under an engineering term?

PS: All kind of pipelines, tunnels and canals are in the waterwaymap graph, just not in the "natural" slice.

flacombe commented 4 months ago

Natural non-artificial flows of water underground deserve one or more tags on their own yet to be found and not get filed under an engineering term?

I'll be all in, once we found the appropriate waterway=* value for that, but we still fail in the public discussion.

PS: All kind of pipelines, tunnels and canals are in the waterwaymap graph, just not in the "natural" slice.

That's fine indeed, I didn't used the view selection accordingly to find them.

amandasaurus commented 3 months ago

I analysed recent OSM data, and if I include waterway=pressurized then there are only 22 more loops than with the current approach of ignoring them. There are ~16,100 waterway loops in OSM now. So +22 isn't a lot. This shows that OSMers aren't causing many

Here's a GeoJSON of the “new loops” when you include =pressurized.

In comparison, someone recently asked for waterway=ditch to be included. Although the wiki says ditches should be mapped how the water flows, there are 28,000 loops in waterway=ditch alone!

Based on this, I will probably put =pressurized back into WWM's “flowing water” category.

https://gist.github.com/amandasaurus/d208b822ce31732256699eabf58f7e42

hungerburg commented 3 months ago

The loops in the GeoJSON look like trivial mapping/tagging errors.

My suggestion was to treat pressurized same as canal -- hide it from the "natural" selection. Is that the same as the "flowing" selection? Perhaps "natural" can mean different things: Pipelines being part or not being part of?