search

amandasharief / psr-session

2 stars 1 forks source link

Avoid calling getId() twice. #2

Open ralflang opened 1 year ago

ralflang commented 1 year ago

In the usage example from readme.

Use falsy '' as condition rather than bool $wasDestroyed. Don't calculate last hour when any non-null past value serves the same purpose.

amandasharief commented 1 year ago

Thanks, I wait until its been reviewed by others since the code was explaining why there is no session id, this will no be longer be clear and explanatory which i need for the proposal, if i accept this request right now, as i think people will then need to ask why is there no id etc.