amandris / arbitrage-trading-bot

Bot to automate trading orders between Bitcoin exchanges to make some profit.
MIT License
42 stars 34 forks source link

Build issue #1

Closed NH603 closed 5 years ago

NH603 commented 5 years ago

Hello, there appears to be a build issue. Based on your knowledge of the code, would you be willing to create a docker-compose.yml/Dockerfile to help build on VM? If not, give me 24 hours to learn code and I’ll submit a PR for us. Thank you in advance for your willingness to help.

amandris commented 5 years ago

Could you provide a little more information about the build issue? I can fix it up if you need it. But you are welcome to create a Dockerfile if you prefer so.

NH603 commented 5 years ago

Thank you very much Amandris. Yes, confronting an issue when trying to run the following command to create database “bin/console doctrine:schema:update --force”. I can attach error message if helpful, but that’s why I thought perhaps containerizing with Docker to support db creation, etc would be a quick fix.

I’ll be standing by ready to help. Thanks again

amandris commented 5 years ago

Yes, attach error message, please. Maybe I forgot some steps on the Installation Readme.md section.

NH603 commented 5 years ago

Hi Amandris,

Yes, please find the error message copied below when entering the command to create database in the Installation Readme.md section. Please let me know if you have any recommendations? Thank you again.

"In AbstractMySQLDriver.php line 93:

An exception occurred in driver: SQLSTATE[HY000] [2002] Connection refused

In PDOConnection.php line 31:

SQLSTATE[HY000] [2002] Connection refused

In PDOConnection.php line 27:

SQLSTATE[HY000] [2002] Connection refused"

amandris commented 5 years ago

Remember to check the database settings are correct in the parameters.yml file.

Also check the database_driver is pdo_mysql.

The database must be previously created. If you didn't create it manually, try to run php bin/console doctrine:database:create before the bin/console doctrine:schema:update --force command.

NH603 commented 5 years ago

Thank you for the quick reply Amandris. It’s very much appreciated; especially when I’m eager to test your extremely impressive app. Unfortunately, still receiving same error when trying steps above. Perhaps, it’s a dependency/extension issue and I’m missing some dependency requirements?

Thanks again for all your support.

amandris commented 5 years ago

I haven't tried with Mysql (only with Postgress) but it should work with any RDBMS right off the shelf. Could you attach your parameters.yml so I can take a look?

NH603 commented 5 years ago

Hello Amandris, I've tried with Postgres as well and database build still does not through with the commands above. Do you perhaps have any helpful suggestions? I'm not sure if you're familiar with docker-compose.yml? But that may be a good option for building symfony, app and database.

Thanks again, and I'll be standing by.

amandris commented 5 years ago

Your parameters.yml looks fine. It seems like you have some kind of connectivity problem. You should use some mysql client and try to connect to the remote DB from your computer. If it works from the client, it should also work from the symfony project. Let me know the results.

amandris commented 5 years ago

Maybe the problem is in the database_password: null parameter. Have you tried to set a password in your DB. Maybe the symfony orm is trying to log in with "null" as password.

mgmerino commented 5 years ago

Hello @NH603, I could wrap this as a Docker container for deploying it easily, but I would need a couple of days to sort it out. If you can wait, I'll ping you when it's ready.

NH603 commented 5 years ago

Hi Manu,

It’s good to hear from you, and yes, that would be extremely helpful! Thank you for your willingness to support with Docker. It’s really much appreciated.

I’ve been still tweaking the database configurations, but to no avail. So based on my DO VM setup, I think Docker may be the easiest option. I’ve been trying to get this repo, which provides a good symfony docker-compose bootstrap foundation, to build and launch the arbitrage-trading-bot. I’m close, but still haven’t got it to all work yet. https://github.com/eko/docker-symfony/blob/master/README.md

On Jan 30, 2019, at 6:52 AM, Manu González notifications@github.com wrote:

Hello @NH603, I could wrap this as a Docker container for deploying it easily, but I would need a couple of days to sort it out. If you can wait, I'll ping you when it's ready.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

NH603 commented 5 years ago

Hello All,

Just a quick update. I’ve tailored the repo to now successfully build all required docker images, but I continue to struggle to actually access the main app/frontend remotely. While I’m working through that, I’m happy to push what I have so far. Otherwise perhaps you’ve made some more progress than I? ;)

On Jan 30, 2019, at 6:52 AM, Manu González notifications@github.com wrote:

Hello @NH603, I could wrap this as a Docker container for deploying it easily, but I would need a couple of days to sort it out. If you can wait, I'll ping you when it's ready.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

NH603 commented 5 years ago

I’m still struggling to get app to launch. Whether in Docker or locally. Can you perhaps share node_modules and var/www folders or as much as you can? Any help would be much appreciated.

Thanks again

On Jan 30, 2019, at 11:24 PM, Zach zachary.goldthwaite@gmail.com wrote:

Hello All,

Just a quick update. I’ve tailored the repo to now successfully build all required docker images, but I continue to struggle to actually access the main app/frontend remotely. While I’m working through that, I’m happy to push what I have so far. Otherwise perhaps you’ve made some more progress than I? ;)

On Jan 30, 2019, at 6:52 AM, Manu González notifications@github.com wrote:

Hello @NH603, I could wrap this as a Docker container for deploying it easily, but I would need a couple of days to sort it out. If you can wait, I'll ping you when it's ready.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

amandris commented 5 years ago

node_modules directory is created when running npm install. Do you still get theSQLSTATE[HY000] [2002] Connection refused error? if so, I think you still have a DB connection issue (not related to the project). If you get any new error message when deploying, please let me know.

NH603 commented 5 years ago

Hi Amandris, Thank you for the reply. Good news, I was successful in getting the application to load!

However, when entering in the following command, I received a response about "No key/secret.." - see copy from command line below. Is this intended? I used the default secret you originally had shared in parameters.yml.dist.

"app@XXXXXX:~/directory/app$ bin/console bot:trade No key/secret/client_idapp@XXXXXX:~/directory/app"

Also, I had enable Binance as the first exchange. Does it take awhile for the Ticker & Differences to populate with api info?

Thanks for all the support! I'm excited to actually start using this.

NH603 commented 5 years ago

Hi Amandris,

I was successful in getting the "bin/console bot:trade" command to work, and while the "Ticker" now populates in the app, I'm receiving the following error once the command is inserted into the command line. Do you have any recommendations on how to resolve?

"app@XXXXXX:~/directory/app$ bin/console bot:trade 05/02/2019 07:29:59 bitstamp Ask:3,418.07 Bid:3,418.06 okcoin Ask:3,416.03 Bid:3,417.72 binance Ask:3,465.98 Bid:3,465.95

In ItbitService.php line 148:

Cannot use object of type stdClass as array"

Thank you in advance for your help on this!

amandris commented 5 years ago

I close this issue and create a new one with your last message.

xazes commented 3 years ago

Hi I have the same problem: bin/console bot:trade result in No key/secret/client_id

I have set enable: false by bitstamp on config.yml