search

amangupta0709 / google-meet-bot

An advance google meet bot which will attend and leave classes and screen record the lectures automatically.
80 stars 19 forks source link

Codebase contains hard-coded links. #5

Open arffsaad opened 2 years ago

arffsaad commented 2 years ago

After inspecting the codebase, a few explicit references to the dev's filesystem is discovered. some contains dirs such as /home/aman/Documents

This can cause a lot of difficulties for people who try to use this in their own environment.

However this may not be the case for docker-based. I am not sure about it. But for linux setup, I'm having difficulties due to these.

LucasRochaAbraao commented 2 years ago

Hi! I'd like to help out on this issue. Can you assign it to me? I've already cloned the repo and made some changes for you to review.

amangupta0709 commented 1 year ago

sure you can

LucasRochaAbraao commented 1 year ago

Hi, sorry for the delay. I have a change but can't open a pull request. When running git push -u origin head from my local branch hard-coded-links I get this error:

ERROR: Permission to amangupta0709/google-meet-bot.git denied to LucasRochaAbraao.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
amangupta0709 commented 1 year ago

Hi, sorry for the delay. I have a change but can't open a pull request. When running git push -u origin head from my local branch hard-coded-links I get this error:

ERROR: Permission to amangupta0709/google-meet-bot.git denied to LucasRochaAbraao.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Hi,

You have to fork this repo and make a new branch in that repo, make the code changes and then open a PR from the forked repo to the this repo

LEvinson2504 commented 1 year ago

@LucasRochaAbraao were you able to raise PR for this issue, I assume a fix for this looks like "{current_dir}/djangobot/botserver/meetbot.py" which will work within docker as well as well as local runserver.

VigneshRamanathan101 commented 1 year ago

Is it still active and not completed?

If so I would like to contribute