search

amanharwara / altus

Desktop client for WhatsApp Web with themes, notifications and multiple account support
GNU General Public License v3.0
476 stars 65 forks source link

feat: remove unused addChatID and fix preload startup detection #204

Closed fznhq closed 2 years ago

fznhq commented 2 years ago

webview needs contextIsolation=false to make sure preload can access reactFiber object

fznhq commented 2 years ago

Hi, thanks for the contribution! I'm not sure what the chat IDs are actually being used for now. I believe I had implemented that for the chat online/offline indicator, but I've since stopped supporting that because it's difficult to keep up with changes in how WhatsApp handles that. I'm inclined to remove that file as well.

Please remove changes reload to that and delete that file as well. We can keep the changes to the preload that are not related to this.

Thanks again for your contribution.

Sure

fznhq commented 2 years ago

@amanharwara thanks, but I forgot to remove the unused import addChatID on preload, can you do that?

amanharwara commented 2 years ago

@amanharwara thanks, but I forgot to remove the unused import addChatID on preload, can you do that?

Yes, done.

fznhq commented 2 years ago

@amanharwara Thanks