"Gap Between Items:" value resets between visits when set to 0. (also "Padding:" value but that doesn't offically support 0 but should)

amanharwara / chartr

A web-app to create custom music charts/collages.

https://chartr.vercel.app/

GNU General Public License v3.0

5 stars 1 forks source link

"Gap Between Items:" value resets between visits when set to 0. (also "Padding:" value but that doesn't offically support 0 but should) #15

Open 111112oo opened 3 years ago

111112oo commented 3 years ago

OS: Windows 10 Browser: w/ version: Firefox 94.0.1

If you leave the site with the "Gap Between Items:" value set to 0, when you return the value will be set to 5. This does not affect loading/exporting chart backups. The same issue also applies to having the "Padding:" value set to 0, being set back to 7 instead, but that is not officially supported (but should be).

On backup load or fresh creation: After page refresh:

json: test-backup.txt

amanharwara commented 3 years ago

Ah I think this is because JavaScript thinks that the 0 value is the same as a false value so it resets it. I'll look into this.

amanharwara commented 3 years ago

This should be fixed now. Please check.

111112oo commented 3 years ago

It is indeed fixed now! Would like official support for padding being set to 0 but it's not hard to do that as a user anyways. Cheers!