search

amanharwara / chartr

A web-app to create custom music charts/collages.
https://chartr.vercel.app/
GNU General Public License v3.0
5 stars 1 forks source link

Enhancement: automated collage sort based on artist name / album name #17

Open matthewjenkins97 opened 2 years ago

matthewjenkins97 commented 2 years ago

This is something that I was thinking of adding because I feel like it'd be useful to an end user. I remember trying to sort both through the GUI and through the arrow keys and it had some usability issues that prevented me from enjoying the experience.

I was thinking we could have a button (maybe in Chart Options) which runs a function which flattens the album list array, sorts the album list array via artist name first and album name second (if by artist) or just by album name (if by album), and then unflattens it so we can sort the collage in order. Perhaps there is a better implementation of this, but this was my gut feeling just seeing some of the code. I'd appreciate your feedback - not sure how useful this would be to others.

Here's a quick mockup:

Before pressing Sort by Album: Before pressing sort by album

After pressing Sort by Album: After pressing sort by album

matthewjenkins97 commented 2 years ago

This can be done after the implementation refresh you mentioned in #12, of course, though I do want to experiment and see if I can implement it before then.

matthewjenkins97 commented 2 years ago

I have something implemented but I want to test it before I ship it via pull request. It seems to work nicely, unless you use the method described in #8 to add via a link, in which case the sort kind of gets thrown off (probably sorting via the link rather than the album name, which I'm using in my implementation). This may need to be bundled with an album name / album description editor of some kind.