`t.rich` return type has become wrong when using it in Next v15 projects together with the new React v19 types

ChristianIvicevic commented 3 weeks ago

Description

After attempting to migrate to Next v15 I noticed a false positive during linting causing linting to fail and I narrowed it down to t.rich behaving differently in terms of types. Without looking into the implementation details it feels like that t.rich relies on some React specific types that were changed in v19.

Verifications

[X] I've verified that the problem I'm experiencing isn't covered in the docs.
[X] I've searched for similar, existing issues on GitHub and Stack Overflow.
[X] I've compared my app to a working example to look for differences.

Mandatory reproduction URL

https://github.com/ChristianIvicevic/next-intl-bug-repro-app-router/tree/next-15

Reproduction description

Steps to reproduce:

Open reproduction which is in the next-15 branch (that is the result of applying the codemod from Next v15 onto the main branch of the reproduction, refer to the commit)
Open app/[locale]/page.tsx in your editor
See error: t.rich returns any

Expected behaviour

In the main branch of the same reproduction you will notice how t.rich is correctly typed and returns string | ReactElement | ReactNodeArray as expected. It being any in the reproduction causes eslint to complain with the no-unsafe-return error.

amannn commented 3 weeks ago

Thanks for the careful reproduction! 🙏

I've opened https://github.com/amannn/next-intl/pull/1445 to address this.

As a side note, if you consider upgrading to Next.js 15 already, you might want to consider https://github.com/amannn/next-intl/issues/1442.

ChristianIvicevic commented 3 weeks ago

Thanks for looking into it! Regarding your warning, I don't use i18n routing anyways, so one less thing to keep track of when migrating.

amannn / next-intl