amannn / next-intl

🌐 Internationalization (i18n) for Next.js
https://next-intl-docs.vercel.app
MIT License
2.63k stars 236 forks source link

Type-safe arguments #410

Open amannn opened 1 year ago

amannn commented 1 year ago

Is your feature request related to a problem? Please describe.

next-intl provides opt-in strict typing for messages. With some additional TypeScript voodoo, it might be possible to support type checking for arguments that need to be passed to t calls.

Resources:

Describe the solution you'd like

{
  "hello": "Hello {name}"
}
t('hello') // Should be an error

We have to evaluate though what it takes to support everything from ICU and also rich text.

Also we should be sure about the performance implications of this (see also https://github.com/amannn/next-intl/issues/792).

Open question: Since we support defaultTranslationValues, type-safety would only cover types (ie. accept only strings, numbers, etc), but not if an argument is provided or not (it could come from the defaults). This begs the question if defaultTranslationValues are really a good idea or if we should get rid of this. https://github.com/amannn/next-intl/issues/611 discusses a separate issue but also comes to the conclusion that defaultTranslationValues might be helpful to remove—an alternative is suggested there too.

Describe alternatives you've considered

Not introducing types for this

DemianParkhomenko commented 1 year ago

It would be an extremely useful feature that speeds up the development)

TommySorensen commented 1 year ago

@amannn I guess this will also help with having different objects of translations for each locale? Currently i load my translations async, but one locale might have more and different translations then the rest.

matannahmani commented 12 months ago

any updates on this one?

loczek commented 11 months ago

You can add a global.d.ts file in the root of your project and it should work

type Messages = typeof import("./messages/en.json");
declare interface IntlMessages extends Messages {}
DemianParkhomenko commented 11 months ago

You can add a global.d.ts file in the root of your project and it should work

type Messages = typeof import("./messages/en.json");
declare interface IntlMessages extends Messages {}

But it does not check arguments, isn't it? i.e. {name} in the example

{
  "hello": "Hello {name}"
}
ScreamZ commented 6 months ago

You can add a global.d.ts file in the root of your project and it should work

type Messages = typeof import("./messages/en.json");
declare interface IntlMessages extends Messages {}

But it does not check arguments, isn't it? i.e. {name} in the example

{
  "hello": "Hello {name}"
}

No it doesn't, as the creator said this requires typescript vodoooooo, you need to use template literal parsing with some kind of recursivity and this might happen. That's a nice first contribution to do.

amannn commented 2 weeks ago

This is coming in next-intl@4! (see https://github.com/amannn/next-intl/pull/1499)

DemianParkhomenko commented 2 weeks ago

Awesome! Great work