search

amanrajrana / RobustKey-PasswordGenerator

"RobustKey: Simplifying Password Generation with React and Tailwind CSS. Join us to enhance online security! 🚀 Great starter for new contributors!"
https://robustkey.mcchzb.in/
7 stars 20 forks source link

added dark mode switch #2

Closed ADHIRAJ-12 closed 1 year ago

ADHIRAJ-12 commented 1 year ago

hey @amanrajrana I've added the dark theme for the calculator. Can you please review it and consider it as a contribution in hacktoberfest. Thanks. Screenshot (83) Screenshot (82)

amanrajrana commented 1 year ago

@ADHIRAJ-12 Can you change the light theme background colour to white?

ADHIRAJ-12 commented 1 year ago

Ya sure ! let me try

ADHIRAJ-12 commented 1 year ago

Attaching ss with white background. @amanrajrana

Screenshot (84)

amanrajrana commented 1 year ago

@ADHIRAJ-12 Your pull request looks good! However, I noticed the absence of the "theme toggle" icon and code in PR. Please add the icon to the navbar to make it easily accessible for users to switch themes

ADHIRAJ-12 commented 1 year ago

@amanrajrana initially i added the toggle switch to the navbar itself, but somehow it was not switching themes brother. if you can help me with this ,i can try .

ADHIRAJ-12 commented 1 year ago

UPDATE: I Figured it out @amanrajrana . Updating the code. Screenshot (85)

ADHIRAJ-12 commented 1 year ago

Update: @amanrajrana i have made a PR separately with the final code. please review that so that we can close this one.