search

amanrajrana / RobustKey-PasswordGenerator

"RobustKey: Simplifying Password Generation with React and Tailwind CSS. Join us to enhance online security! 🚀 Great starter for new contributors!"
https://robustkey.mcchzb.in/
7 stars 20 forks source link

added Github link with logo #47

Closed GautamTirumala closed 1 year ago

GautamTirumala commented 1 year ago

Fix #46 Light mode Dark mode also done. Responsiveness for all devices.

Screenshot 2023-10-12 225122 Screenshot 2023-10-12 225134 Screenshot 2023-10-12 225145

GautamTirumala commented 1 year ago

Hi @amanrajrana I totally agree with the 1,3 point and I have completed the changes. The second point "it would be great if, for larger screens, we could center-align the navigation links." It looks wired to me having the navigation buttons in the center, they should be on the right side only,

I have also researched on other websites and found the same. When I visit a website I expect the nav links on the right side of the navbar.

I will be waiting for your thoughts on this.

Currently my PR looks like this if you give me clarity on point 2 I will complete the changes if required and make a PR

Screenshot 2023-10-13 113817 Screenshot 2023-10-13 113837

amanrajrana commented 1 year ago

Your code breaks the navbar responsiveness on the mobile screen. It is not responsive at the width of less than 400px.