search

amansrivastava17 / embedding-as-service

One-Stop Solution to encode sentence to fixed length vectors from various embedding techniques
MIT License
204 stars 29 forks source link

Fix reference to vector file for fasttext #55

Closed akoumjian closed 4 years ago

akoumjian commented 4 years ago

This closes #54 This particular model zip archive has two files in it. Originally, the first file found was loaded, but depending on the operating system / filesystem this was not always the .vec file. Updated to explicitly load the .vec file rather than first file found.

Sorry about the automatic formatting, I can remove it later if you like when I have more time.

amansrivastava17 commented 4 years ago

Hi @akoumjian, Thanks for bringing this up. I will have a look at this PR, will ping if any changes are required.

Also, no issue regarding the automatic formatting :)

amansrivastava17 commented 4 years ago

Hey @akoumjian, Changes look good to me. Thank you for your contribution. 👍

amansrivastava17 commented 4 years ago

@all-contributors please add @akoumjian for bug fix related to loading fasttext vector

allcontributors[bot] commented 4 years ago

@amansrivastava17

I've put up a pull request to add @akoumjian! :tada: