Closed amirhessampourhossein closed 7 months ago
In your JwtTokenGenerator class there are two magic strings used as custom claim names. we could use constants like below 👇
JwtTokenGenerator
public static class CustomClaims { public const string Id = "id"; public const string Permissions = "permissions"; }
what do you think ? @amantinband
Nah, when constant strings are used only in one place and there isn't added value by extracting them to a separate location I prefer inlining them.
In your
JwtTokenGenerator
class there are two magic strings used as custom claim names. we could use constants like below 👇what do you think ? @amantinband