Graphs turn red although "hot" sensors with bad reasings have been removed from graphs and summaries - Githubissues

amanusk / s-tui

Terminal-based CPU stress and monitoring utility

https://amanusk.github.io/s-tui/

GNU General Public License v2.0

4.01k stars 139 forks source link

Graphs turn red although "hot" sensors with bad reasings have been removed from graphs and summaries #193

Open KyodaiKen opened 2 years ago

KyodaiKen commented 2 years ago

Step 1: Describe your environment

System: AMD Ryzen 5600G on ASRock A520M-ITX/ac (WiFi module removed)
OS version: Ubuntu Server 22.04 minimum installation
s-tui version: 1.1.3
Installation method: pip via root

Step 2: Describe the problem:

Observed Results:

Temperature graphs turn red because some of the AUXTIN sensors report temperatures over 100 degrees.

Expected result:

Expectation would be that those sensors are not being included into the colorizing and scaling of the graphs since I have hidden the sensors from the graphs AND summaries. So the colors should be green.

Debug Results, output of `s-tui -d` created in a file `_s-tui.log`:

Step 3: Reproduce the problem:

Steps to reproduce:

Open s-tui using sudo
Observe the graphs being red

amanusk commented 2 years ago

Thank you for the issues and for the interest in the project. Indeed this is the case right now. The threshold for temperatures is set globally and not per-sensor. The color change is triggered after the probing of all the sensors, and not based on the graphs displayed.

Let's leave this issue open to hopefully get to it one day. PRs are welcome of course :)