search

amanwas / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Page size #513

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Add 2 functions to display page size.
We have metric and inches. 
Output them as spans with IDs and numbers only as the content so the user can 
choose what units they want to display.

Let's discuss what the interface and the result should look like.

Original issue reported on code.google.com by zetapri...@gmail.com on 5 Apr 2011 at 1:32

GoogleCodeExporter commented 9 years ago 
We need mockups where and how this may be displayed.

Original comment by ad...@zetaprints.com on 18 Apr 2011 at 9:29

GoogleCodeExporter commented 9 years ago 
Lets talk about it. Not clear enough to make mockups.

Original comment by agur...@gmail.com on 18 Apr 2011 at 11:43

GoogleCodeExporter commented 9 years ago 
Look at stickers for example. What's the page size? No one knows.
The info is in the XML for the template. We just need to display it somewhere.

Make a mock up with this bit of info inserted somewhere.
They will need to insert it into a custom theme wherever they want, but we need 
to make it look good in the default theme.

Original comment by ad...@zetaprints.com on 18 Apr 2011 at 11:46

GoogleCodeExporter commented 9 years ago

Original comment by agur...@gmail.com on 20 Apr 2011 at 10:17

Attachments:

GoogleCodeExporter commented 9 years ago 
> Add 2 functions to display page size.

Which two functions?

Original comment by Anatoly....@gmail.com on 26 Apr 2011 at 7:54

GoogleCodeExporter commented 9 years ago 
1 for inches, 1 for cm
Can be one with a parameter, but must be dead simple.

Original comment by ad...@zetaprints.com on 26 Apr 2011 at 8:42

GoogleCodeExporter commented 9 years ago 
You'll probably need the icon as well, Anatoly. Give me the sprite that I 
should add it to. 
Attaching it on its own.

Original comment by agur...@gmail.com on 26 Apr 2011 at 9:21

Attachments:

GoogleCodeExporter commented 9 years ago 
Diffs:

* http://code.google.com/p/magento-w2p/source/detail?r=1627
* http://code.google.com/p/magento-w2p/source/detail?r=1628

Wiki:

* http://code.google.com/p/magento-w2p/source/detail?r=1629
* http://code.google.com/p/magento-w2p/source/detail?r=1630

Tested in Tested in IE7, IE8, FF 3.5, Chrome 6, Opera 10, Opera 11 and Safari 5

Original comment by Anatoly....@gmail.com on 23 May 2011 at 6:13

GoogleCodeExporter commented 9 years ago 
Please, test it with 1.9.1.0beta1 release.

Original comment by Anatoly....@gmail.com on 25 May 2011 at 2:01

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0beta1 (beta)

1. How about we narrow it down to a few digits only (narrow_down.png):
http://d1.zetaprints.com/mageimage/index.php/mageimg-02/20-fields-x-text-and-ima
ge.html
I'm thinking rounded up to the nearest number at the 3rd digit after the 
decimal. What do you guys think?

2. Can you add an empty space between the number and the units (in_space.png)?

3. Some products show the sizes while others don't. I think I figured out where 
the conflict might be but you better look into it yourself. Page sizes are 
shown only if the template has file downloading set to "allow" in portal end. 
Ex. this template
http://d1.zetaprints.com/mageimage/index.php/mageimg-02/remax-3img.html
shows no sizes. Set the file downloading to "Allow" for it here:
http://cname.zetaprints.com/?page=template-modify;TemplateID=EAC50899-D745-4669-
80D8-D93D1E2F99EE
and refresh the M. product page. The sizes show.

Help pages need to be updated:
http://www.zetaprints.com/magentohelp/custom-theme-integration/
http://www.zetaprints.com/magentohelp/custom-2step-theme/

Original comment by agur...@gmail.com on 26 May 2011 at 1:19

Attachments:

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Definitely. Round it to 2 decimals.

Original comment by ad...@zetaprints.com on 26 May 2011 at 8:26

GoogleCodeExporter commented 9 years ago 
Remove it from zptheme. Customers will add the function to custom themes when 
they need it.

Original comment by Anatoly....@gmail.com on 31 May 2011 at 10:02

GoogleCodeExporter commented 9 years ago 
Do not show table at all when PDF, JPG and GIF/PNG output files are disabled in 
template details.

Original comment by Anatoly....@gmail.com on 2 Jun 2011 at 6:52

GoogleCodeExporter commented 9 years ago 
> 1. Round numbers to 2 decimals after a comma.

http://code.google.com/p/magento-w2p/source/detail?r=1659

> 2. Can you add an empty space between the number and the units (in_space.png)?

http://code.google.com/p/magento-w2p/source/detail?r=1660

> Remove it from zptheme. Customers will add the function to custom themes
> when they need it.

http://code.google.com/p/magento-w2p/source/detail?r=1666

> Do not show table at all when PDF, JPG and GIF/PNG output files are disabled 
in
> template details.

http://code.google.com/p/magento-w2p/source/detail?r=1667

Original comment by Anatoly....@gmail.com on 2 Jun 2011 at 6:09

GoogleCodeExporter commented 9 years ago 
Please, test it with 1.9.1.0beta2 release.

Original comment by Anatoly....@gmail.com on 2 Jun 2011 at 6:49

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 2 Jun 2011 at 7:01

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 7 Jun 2011 at 1:19

GoogleCodeExporter commented 9 years ago 
Can't test it because now that the feature is removed from zptheme, I don't 
know how to activate it. Maybe a separate Wiki is in order? Or just a more 
detailed section in the existing Wiki on "custom theme native"?
What code to paste and where? This will go in the help post as well.

Original comment by agur...@gmail.com on 8 Jun 2011 at 10:50

GoogleCodeExporter commented 9 years ago 
The page size are showed incorect for multipage templates
The line 447 must be replaced from
      <td class="page-size-table-icon" rowspan="2">
to somethink like 
      <td class="page-size-table-icon" rowspan="$page_count+1">

Original comment by Sandis.S...@gmail.com on 9 Jun 2011 at 10:16

GoogleCodeExporter commented 9 years ago 
@20 - thanx

Original comment by ad...@zetaprints.com on 9 Jun 2011 at 10:39

GoogleCodeExporter commented 9 years ago 
Atanas, look for Optional section at 
http://code.google.com/p/magento-w2p/wiki/CustomThemeNative#Files_in_app/design/
frontend/default/%3Cyour_theme_name%3E/

Original comment by Anatoly....@gmail.com on 9 Jun 2011 at 12:14

GoogleCodeExporter commented 9 years ago 
How come it used to be right under the input form and now I can make it show up 
anywhere but there?
http://d1.zetaprints.com/mageimage/index.php/mageimg-01/template.html

Bottom line, since this is something that requires someone that knows what they 
are doing, is it safe to say that adding the info to the wiki is all developers 
actually need? For someone at my level, I'm having problems positioning it 
where "Quick overview" is without using CSS.

Original comment by agur...@gmail.com on 9 Jun 2011 at 3:16

GoogleCodeExporter commented 9 years ago 
Can you modify a template somewhere so I can see it in action?

Original comment by ad...@zetaprints.com on 10 Jun 2011 at 9:25

GoogleCodeExporter commented 9 years ago 
http://d1.zetaprints.com/mageimage/index.php/mageimg-01/template.html

It is right under the image fields

Original comment by agur...@gmail.com on 20 Jun 2011 at 10:22

GoogleCodeExporter commented 9 years ago 
What about the issues? Let's re-test it.

Original comment by Anatoly....@gmail.com on 19 Aug 2011 at 5:53

GoogleCodeExporter commented 9 years ago 
Tested on /magedev/
http://d1.zetaprints.com/magedev/index.php/magentot-01/1pg-template.html

and /mageimage/
http://d1.zetaprints.com/mageimage/index.php/magentot-01/1pg-template.html

Turns out this thing is very "cache" prone. Managed to position it only by 
restarting lighty on each change. Just a note for the help post.

Original comment by agur...@gmail.com on 23 Aug 2011 at 4:11

GoogleCodeExporter commented 9 years ago 
Help:
http://www.zetaprints.com/magentohelp/display-page-sizes/

Wiki:
http://code.google.com/p/magento-w2p/wiki/CustomThemeNative#Files_in_app/design/
frontend/default/%3Cyour_theme_name%3E/

Original comment by agur...@gmail.com on 6 Sep 2011 at 3:43

GoogleCodeExporter commented 9 years ago 
How come this product have NaN for page size ?
http://d1.zetaprints.com/mageimage/index.php/sample-stationery/subcategory-01/bu
siness-card.html

Original comment by ad...@zetaprints.com on 7 Sep 2011 at 3:52

Attachments:

GoogleCodeExporter commented 9 years ago 
Heh, that's one of those ancient templates we have in there. There's something 
wrong with it and I can't download the file and see. I get a blank file when I 
try to.

Anyway, this (also old) template was showing the same NaN values in the size 
table:
http://d1.zetaprints.com/mageimage/index.php/sample-stationery/subcategory-01/cd
-label.html
but I was able to fix it using the same method we use for all "new" features on 
old templates. I reprocessed it. So, my conclusion is that old templates need 
to be reprocessed in order to show the page size correctly.
That template you found cannot be fixed, I don't know why.

Original comment by agur...@gmail.com on 7 Sep 2011 at 8:24

GoogleCodeExporter commented 9 years ago 
True.
Can u grab the XML for this template from ZP and post it here?
Old or new, there should be no NaN.

Original comment by ad...@zetaprints.com on 7 Sep 2011 at 9:42

GoogleCodeExporter commented 9 years ago 
XML of the err template:
http://cname.zetaprints.com/?page=template-xml;TemplateID=9B8BB2CC-6036-4664-A6B
6-9912BDCFB4FA

Another template with "NaN" that is old and hasn't been reprocessed:
http://cname.zetaprints.com/?page=template;TemplateID=467C0FF1-89F5-4F3E-B66B-07
84BBBD9F54
on mageimage:
http://d1.zetaprints.com/mageimage/index.php/sample-stationery/subcategory-02/re
al-estate-a6-card.html
its XML:
http://cname.zetaprints.com/?page=template-xml;TemplateID=467C0FF1-89F5-4F3E-B66
B-0784BBBD9F54

Original comment by agur...@gmail.com on 7 Sep 2011 at 10:16

GoogleCodeExporter commented 9 years ago 
Such old templates don't contain size attrs at all

Original comment by Anatoly....@gmail.com on 7 Sep 2011 at 10:24

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
NaN: http://code.google.com/p/magento-w2p/issues/detail?id=647

Docos: how come this is dependent on allowing file download?

Original comment by ad...@zetaprints.com on 7 Sep 2011 at 11:59

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 7 Sep 2011 at 11:59

GoogleCodeExporter commented 9 years ago 
Posted a separate issue for that:
http://code.google.com/p/magento-w2p/issues/detail?id=649

Original comment by agur...@gmail.com on 8 Sep 2011 at 9:57

GoogleCodeExporter commented 9 years ago 
@35

Max. see comment #10

Original comment by Anatoly....@gmail.com on 8 Sep 2011 at 6:31

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 2 Oct 2011 at 8:43

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 3 Oct 2011 at 8:26

GoogleCodeExporter commented 9 years ago 
Are we gonna make it independent of "Download" permission? The post is ready 
for the current scenario:
http://www.zetaprints.com/magentohelp/display-page-sizes/

Original comment by agur...@gmail.com on 31 Oct 2011 at 7:05

GoogleCodeExporter commented 9 years ago 
@41 - Is it still dependent on it?

Original comment by ad...@zetaprints.com on 31 Oct 2011 at 7:12

GoogleCodeExporter commented 9 years ago 
Yes, it has been dependent since the beginning of the feature.
We either need to add a checkbox in template details or keep the "Allow 
download" approach, which may not be very practical.

Original comment by agur...@gmail.com on 31 Oct 2011 at 7:19

GoogleCodeExporter commented 9 years ago 
Let's open a new issue for it. This one is too crowded and already closed 
anyway.

Original comment by ad...@zetaprints.com on 31 Oct 2011 at 9:34

GoogleCodeExporter commented 9 years ago 
there already is one:
http://code.google.com/p/magento-w2p/issues/detail?id=649

but do we release as is or wait for the "independent" issue to be resolved?

Original comment by agur...@gmail.com on 1 Nov 2011 at 10:53

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 1 Nov 2011 at 6:46

GoogleCodeExporter commented 9 years ago 
Edited the post to reflect the latest changes (independent of file download 
permission). Ready for publishing:
http://www.zetaprints.com/magentohelp/display-page-sizes/

Original comment by agur...@gmail.com on 21 Nov 2011 at 2:26

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 21 Nov 2011 at 9:11