amanzi / ats

Advanced Terrestrial Simulator (ATS) development
Other
47 stars 35 forks source link

add evaluators for interpolation in time, use them in ats transport #186

Open ecoon opened 1 year ago

ecoon commented 1 year ago

There is a lot of weird code in ATS transport based on the need for transport to manually interpolate between an "old saturation/density" and a "new saturation/density" onto a subcycled old and new value.

This would all go away and be much cleaner if these were evaluators. To do this we need:

  1. a time interpolating evaluator
  2. refactor the transport pk to use sat/dens at the right tag instead of hard-coding in "flow tags"
ecoon commented 1 month ago

Note the current use of tags (or non-use) in transport means that transport subcycling is broken.