amaranth-lang / amaranth-soc

System on Chip toolkit for Amaranth HDL
BSD 2-Clause "Simplified" License
84 stars 31 forks source link

wishbone.bus: add Arbiter. #9

Closed jfng closed 4 years ago

jfng commented 4 years ago

Wednesday Jan 22, 2020 at 14:18 GMT Originally opened as m-labs/nmigen-soc#3

This arbiter should be compatible with all the optional features of wishbone.Interface.

The round-robin implementation could perhaps be moved to nmigen.lib and imported back here, but that would make nmigen-soc depend on a later revision than nmigen v0.1.

codecov[bot] commented 4 years ago

Codecov Report

Merging #9 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   99.59%   99.63%   +0.04%     
==========================================
  Files           4        4              
  Lines         493      552      +59     
  Branches      107      127      +20     
==========================================
+ Hits          491      550      +59     
  Misses          1        1              
  Partials        1        1
Impacted Files Coverage Δ
nmigen_soc/wishbone/bus.py 98.97% <100%> (+0.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8f8982...87ab698. Read the comment docs.

jfng commented 4 years ago

Thanks for the review !