hdl.ast: replace slice.end by slice.stop in ValueKey

[nmigen-issue-migration]

Issue by psurply Sunday Jan 05, 2020 at 19:51 GMT Originally opened as https://github.com/m-labs/nmigen/pull/295

---

This patch fixes the following warning which is reported when RTLIL is generated from a design that uses slices:

nmigen/nmigen/hdl/ast.py:1505: DeprecationWarning: instead of `slice.end`, use `slice.stop`
    self._hash = hash((ValueKey(self.value.value), self.value.start, self.value.end))

Signed-off-by: Pierre Surply pierre.surply@lse.epita.fr

---

psurply included the following code: https://github.com/m-labs/nmigen/pull/295/commits

[nmigen-issue-migration]

Comment by codecov[bot] Sunday Jan 05, 2020 at 20:03 GMT

---

Codecov Report

Merging #295 into master will not change coverage. The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files          34       34           
  Lines        5647     5647           
  Branches     1160     1160           
=======================================
  Hits         4638     4638           
  Misses        864      864           
  Partials      145      145

Impacted Files	Coverage Δ
nmigen/hdl/ast.py	87.19% <0%> (ø)	:arrow_up:
nmigen/tracer.py	94.59% <0%> (ø)	:arrow_up:
nmigen/hdl/ir.py	94.43% <0%> (ø)	:arrow_up:
nmigen/back/pysim.py	92.32% <0%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 476ce15...d056ae8. Read the comment docs.

[nmigen-issue-migration]

Comment by psurply Sunday Jan 12, 2020 at 14:32 GMT

---

Never mind, it looks like this got fixed with e18385b. Thanks!

[nmigen-issue-migration]

Comment by whitequark Sunday Jan 12, 2020 at 14:33 GMT

---

Yep, I didn't merge it because I had a git stash already that became e18385b.