Ensure that all submodules are added to the design

amaranth-lang / amaranth

A modern hardware definition language and toolchain based on Python

https://amaranth-lang.org/docs/amaranth/

BSD 2-Clause "Simplified" License

1.59k stars 175 forks source link

Ensure that all submodules are added to the design #5

Closed nmigen-issue-migration closed 5 years ago

nmigen-issue-migration commented 5 years ago

Issue by whitequark Friday Dec 14, 2018 at 17:39 GMT Originally opened as https://github.com/m-labs/nmigen/issues/3

17:26 < sb0> whitequark: https://github.com/m-labs/nmigen/blob/master/examples/alu_hier.py#L41-L42
17:26 < sb0> a typical bug is forgetting to add this in migen. would there be a way of addressing this issue in nmigen?

nmigen-issue-migration commented 5 years ago

Comment by whitequark Sunday Apr 21, 2019 at 08:19 GMT

This is actually quite complicated now that we use the elaborate method, since forgetting to add a submodule means that no nMigen code ever runs for that object.