search

amarao / sdled

Control fault/locate indicators in disk slots in enclosures (SES devices)
GNU General Public License v2.0
54 stars 21 forks source link

Fix ALL status setting #3

Closed kruton closed 8 years ago

kruton commented 8 years ago

When requesting ALL set to a certain status, it will abort after the first drive because of an inverted check.

amarao commented 8 years ago

Hello.

About 'if not status' - yes, it looks like a bug.

About writing both locate and fault for 'off' operation - did you ever saw it IRL? As far as I saw on real hardware, locate/fault state files are flags for one internal state - if you change one, you change others.

If you saw different behavior on real hardware, can you look for it name? Thanks.

kruton commented 8 years ago

Oh, I think you're right. The if not status bug must have been the real culprit in the behavior I was seeing. I'll update the pull request.

kruton commented 8 years ago

I have verified setting fault to 0 also turns off locate on the two different enclosures I tested it on: Rackables SE3016 and Supermicro BPN-SAS-836EL2.

amarao commented 8 years ago

thanks!