GOOD off applying for devices didn't marked as fault only

amarao / sdled

Control fault/locate indicators in disk slots in enclosures (SES devices)

GNU General Public License v2.0

54 stars 21 forks source link

GOOD off applying for devices didn't marked as fault only #7

Closed dthpulse closed 3 years ago

dthpulse commented 3 years ago

It's safer to do not apply 'ALL off' to devices marked as fault. Fault devices LEDs can be turned off by specifying device exactly like

encled /dev/sdbo off

amarao commented 3 years ago

Thank you for your feedback and efforts!

I think ALL means ALL. You have an additional case to worry about. Can you, please, to adjust code to support both cases? May be your case can be encoded as 'GOOD' (encled GOOD off, which turn off all non-faulty indicators). And encled ALL off is, well, literally, ALL off.

dthpulse commented 3 years ago

Hi amarao, you're right. I've implemented the changes according your suggestions.

thx!

amarao commented 3 years ago

Thank you a lot for your contribution, it looks nice!

dthpulse commented 3 years ago

Thank you George!