search

amarbajric / EBUSA-AIM17

BPMaaS. Platform for buying, selling and reviewing processes
MIT License
2 stars 3 forks source link

Approval-View (Refinement) #100

Closed amarbajric closed 6 years ago

amarbajric commented 6 years ago

Refinement and refactoring according to the comments issued at the PR #90

Graf-Carello commented 6 years ago

Now the approval page and approval-details page are two seperate pages, and if an approver clicks on one process of the list of all processes, he gets to the details page, where he can approve or disapprove of a process, which now works with data from the backend.

There is still a problem with the backend response concerning the approved attribute of a specific process. The backend always returns false at the moment, even if the data in the SQL DB is actually true.

And it is not fully clear to me if the review comment should just be the attribute processApproverComment (of the process itself) or if a row in the actual review table should be used for comments. Nevertheless some kind of endpoints in the backend are still needed for this.

tortmann commented 6 years ago

does the GET request also return "false" within the response body?

Graf-Carello commented 6 years ago

Yes, the GET request returns "false" within the response body, even though it should be "true" (and is actually true in the SQL-DB).