amarbajric
commented
6 years ago At first glance the idea is kinda acceptable. Nevertheless, there are some aspects which need refactoring and adaptations.
1.
This section should be the parent component (i.e. this is what an approver should see if he visits the tab Approval Page.)
This section should be something like the approval-details page (i.e. when the approver selects one process from the list illustrated in the picture above)
ToDo:
- Split the list of processes which need approval and the process-details section into parent and child component
- parent component => list of processes which need approval (with a simple list which shows user who uploaded it, name of process, description)
- child component => if you click on one of the processes (that need approval) in the list of the parent component, another view should load where the information of the process and the user is shown, and where all comments are shown and the commenting, approve and rejection section should be at the bottom
NOTE: As the process store is not yet implemented, it is only required to do the tasks mentioned above. Logic and final implementation hast to wait until the backend is ready. Best case scenario would be however, if you just take some mockup data and test it with them (just look up some tuts. on how to create mockup data in Angular)
Graf-Carello
resolves #87 This is the initial implementation of the approval page. Further To-Do is to implement the actual API calls to the specific endpoints to use real data instead of test data.