amarghosh / mp4viewer

MP4 file analyser for converting ISO-bmff atoms into json, or display them on the command line or a GTK based window
https://pypi.org/project/mp4viewer/
MIT License
52 stars 20 forks source link

improve flags as hex #12

Closed marakew closed 7 months ago

marakew commented 8 months ago

https://github.com/amarghosh/mp4viewer/blob/720f65c266618d48be8a18cbecad53cb23f62026/src/isobmff/fragment.py#L47

yield("Default sample flags", "0x%08x" %self.default_sample_flags)

https://github.com/amarghosh/mp4viewer/blob/720f65c266618d48be8a18cbecad53cb23f62026/src/isobmff/fragment.py#L89

yield('First sample flags', "0x%08x" %self.first_sample_flags)

amarghosh commented 8 months ago

Thanks for raising this. I am currently working on adding pylint checks to the repo, I will take care of these as part of that. If you need this fixed quicker, feel free to raise a PR.

marakew commented 8 months ago

I'm in no hurry

вт, 5 мар. 2024 г. в 14:23, Amarghosh Vadakkoot @.***>:

Thanks for raising this. I am currently working on adding pylint checks to the repo, I will take care of these as part of that. If you need this fixed quicker, feel free to raise a PR.

— Reply to this email directly, view it on GitHub https://github.com/amarghosh/mp4viewer/issues/12#issuecomment-1978656233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3OABZLFT3MKZO66PTHJALYWW2NXAVCNFSM6AAAAABEGSOTKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYGY2TMMRTGM . You are receiving this because you authored the thread.Message ID: @.***>