search

amark / gun

An open source cybersecurity protocol for syncing decentralized graph data.
https://gun.eco/docs
Other
18.14k stars 1.17k forks source link

Dynamic dependency in react-native/expo #1163

Closed aethiop closed 2 years ago

amark commented 2 years ago

@aethiop this is great progress. Unfortunately it causes browser to break, tho I think it gives me a new hint on how to fix, let's schedule another call and try it out. Thanks so much for helping with this!

sirpy commented 2 years ago

I dont see why the require for external packages should use "USE" it should use directly require just like the fix I introduced in GoodDollar/gun sea.js repo. It works perfectly fine on native and web, please copy the fix from there

aethiop commented 2 years ago

@amark Yes I'm aware...And sure lets schedule a meeting and go from there. And as @sirpy said external packages should just use require, that seems to fix the problem.

amark commented 2 years ago

sigh did I never merge your edit @sirpy ? I know I'm bad and lagging behind. (oh, maybe it conflicted with the rewrite, but now that's done, should be easy now) Can you link or re-PR it?

Also, gmail is hiding my GitHub issues/pulls notifications, and I can't find how to reset it, grr.

amark commented 2 years ago

@aethiop will you close this since your other one is correct?