Open kengoldfarb opened 2 years ago
This is fixed in the latest master
branch but broken in the latest npm published version
@kengoldfarb yeah, sorry this was super embarrassing terrible mistake. I handled \
ASCII but didn't notice this.
It gets worse tho, you're right somebody already fixed this, but that library they switched to is breaking on other data 😭 .
We can't do native because it blocks the thread for 0.25s which compounds on multiple requests.
Are you good at knowing what other utf8/etc. escapes/checks need to be handled? I'm scared to republish unless somebody smarter than me can peek at https://github.com/amark/gun/blob/master/test/common.js#L85-L94 .
Observed in: Nodejs v14 Version: gun@0.2020.1235
Result in console:
Removing the
\n
results in data being writtenIt's also interesting to note that using the same version of gun in browser, I can not reproduce this bug
adding
console.log({u, data, packed))
just before this line: https://github.com/amark/gun/blob/852b77f49a10d3105400e7057908eeca30c4b679/sea.js#L1437With the
\n
removed I see: