search

amark / gun

An open source cybersecurity protocol for syncing decentralized graph data.
https://gun.eco/docs
Other
18.05k stars 1.16k forks source link

LEX improvement #1204

Open orimay opened 2 years ago

orimay commented 2 years ago

Must be ES5-compatible. Passes 'match text' test ;)

amark commented 2 years ago

@Orimay 🔥 it looks right, the LEX tests are passing. Deleting my lines of code is the best gold a JSgolfer like me can receive :D :D pure outgamed bliss, I bow to you, this is Objective Truth, Scientific Beauty, and makes my heart sing.

.certify( keeps timing out, usually timeout errors are a problem with the VMs the test runners are on, but .certify( heavily uses LEX so we still may have more digging. You've proven this can work tho. Even if its not a silly thing, it'll make sense to update certify to comply with your simpler/cleaner approach. Do they pass on your machine, or think we need to do another call?

orimay commented 2 years ago

Which test would that be?

amark commented 2 years ago

@Orimay https://github.com/amark/gun/blob/master/test/sea/sea.js#L566-L701 .

I hope you're talents & brain are in a healthy place!