search

amark / gun

An open source cybersecurity protocol for syncing decentralized graph data.
https://gun.eco/docs
Other
18.03k stars 1.16k forks source link

Allow {pair.pub} to login with pass #1233

Closed bmatusiak closed 2 years ago

bmatusiak commented 2 years ago

Allow {pair.pub} to login with pass

bmatusiak commented 2 years ago

with a fix for s3 (that affected Heroku) https://github.com/amark/gun/issues/1232

amark commented 2 years ago

Oh nice! Epic. I didn't go line for line but it looked like roughly the right places for stuff to be done. (And since this is security stuff, NOTHING looked weird/fishy. Yay!)

Would you be willing to add a test for this? test/sea/sea.js copy one of the it functions (ones in the middle may be easier to reuse) then swap in sample login code/test. Then open ../mocha.html in browser from file or run mocha command line in repo root.

thank you thank you thank you!

bmatusiak commented 2 years ago 
      ✓ login users (560ms)
      ✓ logout, login via {pub} (399ms)
      ✓ save data (273ms)
amark commented 2 years ago

👏 👏 👏 🔥 🔥 🔥 @bmatusiak !!!