search

amark / gun

An open source cybersecurity protocol for syncing decentralized graph data.
https://gun.eco/docs
Other
18.03k stars 1.16k forks source link

unbuild is no longer silent #1239

Closed bmatusiak closed 2 years ago

bmatusiak commented 2 years ago

instead, it shows us what files were changed from the last unbuild

bmatusiak commented 2 years ago

should we fix workflow to always run npm install ?

amark commented 2 years ago

Will this generate new folder names that get committed? old_gun etc. ? Versus just letting git show us diffs (?)

bmatusiak commented 2 years ago

git repo info is not always around.. especially if you npm install github://url

It should not generate a new folder to be committed. it should act as it was.. it only tells what file was changed.. but not the changes made, (this could be done with extra dependencies)

old logic will delete ./src originally

this logic moves the folder to old_src.. does !(old_src/file.js == src/file.js) console.log ... then at the end, deletes old_src folder

I just like seeing some kinda output. and changes felt like a worthy output of the task

amark commented 2 years ago

Ahhhh! Ok, I missed that rm at the end. Perfect. Sorry, yes this is great.

Thank you once again, I really appreciate it. pulling!!