search

amark / gun

An open source cybersecurity protocol for syncing decentralized graph data.
https://gun.eco/docs
Other
17.96k stars 1.16k forks source link

Allow Dockerfile to auto-update Node version #1302

Closed atjn closed 1 year ago

atjn commented 1 year ago

The Docker version of GUN is running on Node 14. I don't see any reason not to upgrade that to Node 18 and get free performance and feature improvements.

Instead of fixing it to Node 18, I have chosen the version that automatically updates to the newest LTS version of Node, for maximum forgettability :)

amark commented 1 year ago

Thanks for catching this!

And you mentioned I should tag @tcurdt for trying to figure out the credential stuff again? Sorry @tcurdt it seems like every so often I ask the same question again which I think was around the docker credential problems we were having on how to get it to auto-deploy. I remember there being a bug in docker that makes it so none of us have access to it. I hope I'm wrong tho?

amark commented 1 year ago

@atjn oops, I did something that caused this git merge to vanish from master - I don't know how that was possible, but can you re-propose this so I can re-merge it? Sorry, thanks.

atjn commented 1 year ago

@amark That sure is weird. Did you force-push your changes? Do you have branch protection rules enabled for the master branch?

tcurdt commented 1 year ago

@amark No, I remember us having access.

IIRC that part was solved.

Wasn't it you not wanting to have automatic releases? It's been too long 🤷‍♂️

Just get in touch e.g. on Twitter https://twitter.com/tcurdt and I am happy help out.

amark commented 1 year ago

@atjn @tcurdt can you set me up with a command or button I can click that will manually deploy it? I don't want it on every push I want it on every npm publish. I'll ping your twitter.

tcurdt commented 1 year ago

What could be done:

You create the release on github here

https://github.com/amark/gun/releases/new

(and not with npm publish) and that would trigger the release to npm and docker.

amark commented 1 year ago

@tcurdt @atjn ok let's do that.

Historically the github releases thing has weirded me out. But if it'll make sure NPM & docker are in sync then that's definitely worth switching over to + its a GUI which <3 <3 <3 is very helpful & prevents me from making CLI mistakes (which I do all the time... like what just happened the other day).