search

amartinhuertas / ExploringGridapHybridization.jl

0 stars 0 forks source link

Port to Gridap 0.17 #7

Closed amartinhuertas closed 2 years ago

amartinhuertas commented 2 years ago

Opening PR in draft mode ... so that we can start a discussion

amartinhuertas commented 2 years ago

Codecov Report

Merging #7 (b8bb769) into main (1aab564) will increase coverage by 2.69%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   80.99%   83.68%   +2.69%     
==========================================
  Files           6        5       -1     
  Lines        1110      901     -209     
==========================================
- Hits          899      754     -145     
+ Misses        211      147      -64
Impacted Files Coverage Δ
src/CellBoundary.jl 84.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1aab564...b8bb769. Read the comment docs.

amartinhuertas commented 2 years ago

@Balaje ... nice work! I am done with my code review comments. Let me know if you have any doubt/issue, you need further clarification etc.

amartinhuertas commented 2 years ago

Hi @Balaje ... I have added some extra comments. Once these are solved, we can accept the PR!

Balaje commented 2 years ago

Hi @Balaje ... I have added some extra comments. Once these are solved, we can accept the PR!

Done @amartinhuertas!