search

amartinhuertas / ExploringGridapHybridization.jl

0 stars 0 forks source link

New method get_glue #8

Closed amartinhuertas closed 2 years ago

amartinhuertas commented 2 years ago

WIP ... Creating PR so that we can start a discussion etc. I would like to be able to create the PR in draft mode, but I am not able to. Not sure why. Perhaps because I am not the owner of the source branch?

amartinhuertas commented 2 years ago

Codecov Report

Merging #8 (2183106) into main (b8bb769) will increase coverage by 0.01%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   83.68%   83.69%   +0.01%     
==========================================
  Files           5        5              
  Lines         901      914      +13     
==========================================
+ Hits          754      765      +11     
- Misses        147      149       +2
Impacted Files Coverage Δ
src/CellBoundary.jl 84.60% <87.50%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8bb769...2183106. Read the comment docs.

amartinhuertas commented 2 years ago

Hi @Balaje ... although we have to follow a somewhat different approach to the one in this PR (I will come back to you with more details soon), I will accept the PR in the meantime so that we have all your changes incorporated in the main branch.