amarullz / windowgestures

GNOME Extension to Manage window with touchpad gestures
https://amarullz.com/
GNU General Public License v2.0
44 stars 6 forks source link

Snapped windows do not resize to "unsnapped" size when moved with gesture #13

Open preppie22 opened 8 months ago

preppie22 commented 8 months ago

When a window is snapped to the left or right of the screen using the 3-finger move gesture and then subsequently unsnapped with the same 3-finger move gesture, the window size does not revert to the original size.

Workaround: Dragging the window using the title bar will revert the size to original.

How to replicate:

  1. Snap window with the 3-finger move gesture (swipe down, then move)
  2. Move the window again with the same gesture as above.
  3. Note that the size of the window remains the same as when it was snapped.
  4. Drag the window by holding the title bar and it will revert to its original (unsnapped) size.
amarullz commented 8 months ago

Screencast from 2023-10-19 13-20-27.webm

I don't have that problem, because it will reset the window position before doing the snapping. Waiting other to report the same problem. or maybe you can provide me the video?

preppie22 commented 8 months ago

Here's a video of the problem as requested. Screencast from 2023-10-25 11-18-56.webm

Also attaching inxi output if it helps:

System:
  Kernel: 6.5.0-10-generic arch: x86_64 bits: 64 Desktop: GNOME v: 45.0
    Distro: Ubuntu 23.10 (Mantic Minotaur)
Machine:
  Type: Convertible System: LENOVO product: 82ND v: Yoga 6 13ALC6
    serial: <superuser required>
  Mobo: LENOVO model: LNVNB161216 v: SDK0J40709 WIN
    serial: <superuser required> UEFI: LENOVO v: H6CN10WW(V1.03)
    date: 05/28/2021
Battery:
  ID-1: BAT1 charge: 38.8 Wh (68.6%) condition: 56.6/60.0 Wh (94.3%)
    volts: 7.9 min: 7.7
CPU:
  Info: 8-core model: AMD Ryzen 7 5700U with Radeon Graphics bits: 64
    type: MT MCP cache: L2: 4 MiB
  Speed (MHz): avg: 1248 min/max: 400/4372 cores: 1: 1987 2: 1605 3: 400
    4: 400 5: 1411 6: 400 7: 400 8: 400 9: 400 10: 1396 11: 400 12: 3909
    13: 1396 14: 400 15: 1870 16: 3205
Graphics:
  Device-1: AMD Lucienne driver: amdgpu v: kernel
  Device-2: Chicony Integrated Camera driver: uvcvideo type: USB
  Display: wayland server: X.Org v: 1.23.2 with: Xwayland v: 23.2.0
    compositor: gnome-shell driver: dri: radeonsi gpu: amdgpu
    resolution: 1920x1080~60Hz
  API: OpenGL v: 4.6 Mesa 23.2.1-1ubuntu3 renderer: AMD Radeon Graphics
    (renoir LLVM 15.0.7 DRM 3.54 6.5.0-10-generic)
Audio:
  Device-1: AMD Renoir Radeon High Definition Audio driver: snd_hda_intel
  Device-2: AMD ACP/ACP3X/ACP6x Audio Coprocessor driver: snd_rn_pci_acp3x
  Device-3: AMD Family 17h/19h HD Audio driver: snd_hda_intel
  API: ALSA v: k6.5.0-10-generic status: kernel-api
  Server-1: PipeWire v: 0.3.79 status: active
Network:
  Device-1: Intel Wi-Fi 6 AX200 driver: iwlwifi
  IF: wlp2s0 state: up mac: <filter>
Bluetooth:
  Device-1: Intel AX200 Bluetooth driver: btusb type: USB
  Report: hciconfig ID: hci0 state: up address: <filter> bt-v: 5.2
Drives:
  Local Storage: total: 476.94 GiB used: 148.69 GiB (31.2%)
  ID-1: /dev/nvme0n1 vendor: Western Digital model: PC SN530
    SDBPMPZ-512G-1101 size: 476.94 GiB
Partition:
  ID-1: / size: 467.35 GiB used: 148.68 GiB (31.8%) fs: ext4
    dev: /dev/nvme0n1p2
  ID-2: /boot/efi size: 1.05 GiB used: 6.1 MiB (0.6%) fs: vfat
    dev: /dev/nvme0n1p1
Swap:
  ID-1: swap-1 type: file size: 4 GiB used: 512 KiB (0.0%) file: /swap.img
Sensors:
  System Temperatures: cpu: N/A mobo: N/A gpu: amdgpu temp: 48.0 C
  Fan Speeds (rpm): N/A
Info:
  Processes: 428 Uptime: 1h 2m Memory: total: 16 GiB note: est.
  available: 13.48 GiB used: 5.76 GiB (42.7%) Shell: Bash inxi: 3.3.29
amarullz commented 8 months ago

ah, I see.. you enabled window tiling from Ubuntu 23.10, forgot what extension name it is.

First try disabled that extension and see if the problem solved.

The main problem is that extension use their own tiling state (not gnome default tiling), and it didn't set window as maximized (vertically) when tiling function executed. It's like just resize the window to some region without set the maximized flags.

Will see the project how it implements and find some workaround about it.

edit: maybe I should try to set maximized vertical to snapped window, moving window should be disabled (doing restore/unmaximize) if window have maximized flag. Will try with enable that extension for test.

preppie22 commented 8 months ago

ah, I see.. you enabled window tiling from Ubuntu 23.10, forgot what extension name it is.

First try disabled that extension and see if the problem solved.

Yep, this solves the problem! Didn't realize there's a conflict there. Maybe you could just mention in the readme that other tiling extensions could cause conflicts.

edit: maybe I should try to set maximized vertical to snapped window, moving window should be disabled (doing > restore/unmaximize) if window have maximized flag. Will try with enable that extension for test.

That would fix it for all tiling assistants I think so that would help keeping other tiling assistants active. Ubuntu tiling assistant is actually quite good for quarter tiling on larger screens.

Thank you for your help and your work on this extension!

amarullz commented 8 months ago

Can you try this fix (with tiling extension enabled)?

windowgestures@extension.amarullz.com.zip

preppie22 commented 8 months ago

Hey, sorry for the late reply. This fixes the problem but the animation is a bit janky. The animation without the tiling assistant is perfect.

On Tue, Oct 31, 2023 at 1:26 AM Ahmad Amarullah @.***> wrote:

Can you try this fix (with tiling extension enabled)?

@.*** https://github.com/amarullz/windowgestures/files/13213836/windowgestures%40extension.amarullz.com.zip

— Reply to this email directly, view it on GitHub https://github.com/amarullz/windowgestures/issues/13#issuecomment-1786729318, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4IBMD7ZIX3JVF343L3B2LYCCY33AVCNFSM6AAAAAA6F42M72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBWG4ZDSMZRHA . You are receiving this because you authored the thread.Message ID: @.***>

-- Piyush Puranik M. S. Computer Science